This repository was archived by the owner on May 9, 2022. It is now read-only.
Remove associated volumes, too#12
Merged
Merged
Conversation
The default is to leave the volumes in place (https://docs.docker.com/engine/reference/api/docker_remote_api_v1.19/#remove-a-container) but hoosegow containers are ephemeral, and any persistent data is in a mounted volume, so that the data can live on after the container is built.
Contributor
|
Seems good. 👍 |
Contributor
|
Nice catch. 👍 |
spraints
added a commit
that referenced
this pull request
Feb 26, 2016
Remove associated volumes, too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker's default is to leave the volumes in place when a container is removed. Hoosegow containers are ephemeral, and any persistent data should be in a mounted volume.
With docker 1.9, mounting a directory
rofrom a different filesystem copies all of the files into the docker storage dir. The volume isn't removed when the container is removed, so we end up with tons of copies of these files that aren't going to get used anymore.cc @parkr @mastahyeti