Restore Rails 2 support #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wahen include ActionController::Base.include(::SecureHeaders) called from reiltie.rb, SecuerHeaders.add_features not defined yet. As a result class/instance methods won't added to ActionController::Base. But introduced in commit 4aee15e
Author
|
Build failure not related to my changes -- seems build for 2.x branch broken. |
Contributor
|
I do plan on maintaining this branch. I can try to fix those up or you can
attempt it but I won't get to this until next week.
…On Thu, Nov 24, 2016 at 01:00 Anton Petrunich ***@***.***> wrote:
Build failure not related to my changes -- seems build for 2.x branch
broken.
Do You plan to maintain this branch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#304 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbYBMGMrOhvOnDqGZ6vvs-MiCAphVS5ks5rBW5igaJpZM4K6UMb>
.
|
solenko
force-pushed
the
2.x
branch
4 times, most recently
from
9fb504e to
07d0ec9
Compare
Author
|
Sorry, I forgot about US holydays. Build fixed. Happy Thanksgiving! |
Contributor
|
Released in 2.5.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PRs:
When include ActionController::Base.include(::SecureHeaders) called from reiltie.rb,
SecuerHeaders.add_features not defined yet.
As a result class/instance methods won't added to ActionController::Base.
But introduced in commit 4aee15e