Skip to content

fix linting issues #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rei-moo merged 4 commits into from
Dec 12, 2025
Merged

fix linting issues #563

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1971c34
Style/ClassMethodsDefinitions
rei-moo Dec 12, 2025
9163b25
Style/OrAssignment
rei-moo Dec 12, 2025
835fe3c
Layout/SpaceInsideHashLiteralBraces
rei-moo Dec 12, 2025
e33bcba
Lint/ParenthesesAsGroupedExpression
rei-moo Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Style/OrAssignment 
Co-authored-by: Tobias Maier <me@tobiasmaier.info>
  • Loading branch information
@rei-moo @tmaier
rei-moo and tmaier committed Dec 12, 2025
commit 9163b25e61b6e3a487d56e1b62935643a6827a99
3 changes: 0 additions & 3 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ AllCops:
TargetRubyVersion: 2.6

# Disable cops that are not consistently available across all Ruby versions
Style/OrAssignment:
Enabled: false

Layout/SpaceInsideHashLiteralBraces:
Enabled: false

Expand Down
2 changes: 1 addition & 1 deletion lib/secure_headers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ def raise_on_unknown_target(target)

def config_and_target(request, target)
config = config_for(request)
target = guess_target(config) unless target
target ||= guess_target(config)
raise_on_unknown_target(target)
[config, target]
end
Expand Down