Skip to content

Text Expander is not compatible with React 19 #62

@mattcosta7

Description

@mattcosta7

React 19 introduced a heuristic based handling for custom elements where it attempts to set a property instead of an attribute if a scalar value is passed to an attribute, where the element has that same property defined on its prototype

TextExpander element has a get keys() on it's prototype, but not set keys(value) {} operation. this creates a situation where react tries to element.keys = ..... which fails because no setter is defined.

We should define a setter to help make this compat. I imagine this same issue would exist using preact or other, similar, vdom implementations

the error:

TypeError: Cannot set property keys of #<TextExpanderElement> which has only a getter

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions