feat(ir): add typed helper for DeleteFiles@1#1071
Merged
Merged
Conversation
Adds `delete_files_step()` to `src/compile/ir/tasks.rs` — a typed factory for the ADO `DeleteFiles@1` task. Required input (`Contents`) is a positional parameter; optional inputs (`SourceFolder`, `RemoveSourceFolder`, `RemoveDotFiles`) are applied via the existing `.with_input(…)` builder on the returned `TaskStep`. Five unit tests are included covering: - default (required-only) construction - optional `SourceFolder` - `RemoveSourceFolder` flag - `RemoveDotFiles` flag - multiline `Contents` patterns Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Contributor
Resolved the merge conflicts and pushed the merge commit: |
github-actions Bot
added a commit
that referenced
this pull request
Jun 17, 2026
…, DeleteFiles@1 helpers to ir.mdx Three typed helpers added in #1063, #1065, and #1071 were missing from the site docs. This patch: - Adds three rows to the Available helpers table in ir.mdx - Updates the tasks.rs module-layout bullet to list all 12 helpers - Updates the cross-reference sentence in extending.mdx to mention the three new entries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed factory function
delete_files_step()forDeleteFiles@1to the ado-aw IR.Motivation
Previously, any code that needed to emit a
DeleteFiles@1task step had to hand-craftTaskStep::new("DeleteFiles@1", ...)with raw string inputs. This PR introduces a well-typed helper that makes the required/optional input boundary explicit and provides a clear, self-documenting API consistent with the other helpers insrc/compile/ir/tasks.rs.Changes
src/compile/ir/tasks.rs:delete_files_step()factory function with 5 unit testsADO Task Reference
DeleteFiles@1Contents(newline-separated glob patterns)SourceFolder,RemoveSourceFolder(bool string),RemoveDotFiles(bool string)API
Validation
cargo build --all-targetscargo test delete_files— 5 tests passcargo clippy --all-targets --all-features --workspace -- -D warningsCreated by the ado-task-ir-contributor workflow.