test: fix weak and incorrect assertions in pr_filters tests

[github-actions]

Test Suite Reduction: src/compile/pr_filters.rs

What was wrong

• test_gate_step_commit_message: assert!(pattern.contains("skip-agent")) is too weak — it passes for any pattern containing that substring, including one with the wildcards stripped. The pattern "*[skip-agent]*" must survive round-trip unchanged.

• test_gate_step_change_count_includes_changed_files_fact: Test name claims to verify that ChangedFileCount transitively depends on ChangedFiles, but the body also set an explicit changed_files filter — so changed_files appeared in spec.facts regardless of the dependency. A regression removing the dependency declaration would have gone undetected.

• test_gate_step_build_reason_include: Match arm used .. to silently skip the fact field inside ValueInSet. A regression wiring the wrong fact (e.g. "pr_title" instead of "build_reason") would not have been caught.

• test_gate_step_build_reason_exclude: Same issue in the ValueNotInSet arm.

• test_gate_step_labels_none_of: Missing check.name and fact assertions. The symmetric test_gate_step_labels_any_of already checked both; this variant was inconsistently weaker.

Changes

Test	Action	Reason
test_gate_step_commit_message	Rewritten	Weak check: contains → assert_eq! on full pattern
test_gate_step_change_count_includes_changed_files_fact	Corrected	Removed changed_files filter so test exercises the declared dependency
test_gate_step_build_reason_include	Strengthened	Added assert_eq!(fact, "build_reason")
test_gate_step_build_reason_exclude	Strengthened	Added assert_eq!(fact, "build_reason")
test_gate_step_labels_none_of	Strengthened	Added check.name and fact assertions for consistency

Verification

• cargo test: 2123 tests pass, 0 failed ✅
• cargo clippy --all-targets --all-features: no warnings ✅

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• spsprodeus21.vssps.visualstudio.com
• spsprodweu4.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"
    - "spsprodweu4.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Test Reducer · 678.1 AIC · ⌖ 36.6 AIC · ⊞ 36.7K · ◷