docs(site): fix slide deck navigation under base path#1153
Merged
Conversation
The deployed deck used history routing with an absolute base, so advancing slides appended the base to the URL (…/ado-aw/slides/ado-aw/slides/4). Switch to relative asset base (--base ./) and hash routing (routerMode: hash) so navigation stays within /ado-aw/slides/#/N and deep-link reloads work on static GitHub Pages hosting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken slide navigation on the deployed intro deck (added in #1152).
The deck was built with history routing under an absolute base (
--base /ado-aw/slides/), so advancing slides appended the base to the URL instead of replacing the route — producing paths like:Fix
routerMode: hash— navigation now stays within a single hash route (/ado-aw/slides/#/4), which is the canonical configuration for static hosting under a subpath (GitHub Pages). Deep-link reloads work without server-side SPA fallback.--base ./— assets are referenced relatively (./assets/…), so they resolve correctly under/ado-aw/slides/regardless of routing.Test plan
Verified the built deck with a headless-browser check (served at its real
/ado-aw/slides/base):…/slides/#/1→…/slides/#/6— no base duplication.…/slides/#/6renders correctly, including the Mermaid SVG diagram.…/slides/#/presenter/1.cd site && npm run buildstill completes; links validation passes.