Skip to content

Add Dark mode support - #842

Merged
githubuser0xFFFF merged 6 commits into
githubuser0xFFFF:masterfrom
esl-ctu:feature/dark-mode
Jun 13, 2026
Merged

Add Dark mode support#842
githubuser0xFFFF merged 6 commits into
githubuser0xFFFF:masterfrom
esl-ctu:feature/dark-mode

Conversation

@miskovoj

@miskovoj miskovoj commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Adds full support for dark mode:

  • New stylesheets and icons
  • Automatic detection of current theme (light/dark)
  • Palette update propagation to user widgets

Changes:

  • For each stylesheet and each icon file a dark variant was added with _dark suffix.
  • Stylesheets were adopted for dark mode while maximizing usage of palette colors
  • CDockOverlay adjusted to use palette colors only and to get updated when application palette changes
  • A setting for stylesheet switching behavior was added to CDockManager offering three options: automatic switching according to application palette and fixed light or dark mode, which follow the current behavior. The automatic setting is default while the fixed modes are designed for manual switching, custom palettes or possible compatibility issues.
  • (Unrelated fix) Tab menu icon was added to focus-highlighting stylesheets

#753

@githubuser0xFFFF githubuser0xFFFF self-assigned this Jun 9, 2026
@githubuser0xFFFF

githubuser0xFFFF commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Thank you very much for your contribution - it is really appreciated. :o)

@githubuser0xFFFF
githubuser0xFFFF merged commit 4124dde into githubuser0xFFFF:master Jun 13, 2026
@githubuser0xFFFF

githubuser0xFFFF commented Jun 26, 2026

Copy link
Copy Markdown
Owner

@miskovoj Thank you for your contribution again. Today I released ADS v5.0.0 with your new dark theme support and highlighted your contribution in the New and Noteworthy section

@miskovoj

miskovoj commented Jun 26, 2026

Copy link
Copy Markdown
Author

@miskovoj Thank you for your contribution again. Today I released ADS v5.0.0 with your new dark theme support and highlighted your contribution in the New and Noteworthy section

You are very welcome. Thank you for all work on this project. By the way, I think this issue can be closed now... #753

ksylvan added a commit to story-wizard/Qt-Advanced-Docking-System that referenced this pull request Jul 3, 2026
@ksylvan
Merge upstream/master (ADS 5.0: dark mode, Wayland DnD, lazy tab fact…
0277da9 
…ory)

Brings in 14 upstream commits incl. dark mode support (githubuser0xFFFF#842), Wayland
drag-and-drop with in-window preview (githubuser0xFFFF#844), auto-hide title bar fix
(githubuser0xFFFF#843), Linux floating-raise fix (githubuser0xFFFF#840), LP360 double-removal fix
(githubuser0xFFFF#838), and lazy CDockWidgetTab creation for Python factories (githubuser0xFFFF#848).

Conflict resolutions:
- DockManager.cpp: keep both new includes (QTimer ours, QStyleHints upstream)
- DockOverlay.cpp: keep fork's AutoHideFeatureEnabled guard structure and
  half-panel edge-band fall-throughs; adopt upstream's GlobalPos parameter
  (new dropAreaUnderCursor(QPoint) overload) instead of QCursor::pos()
- FloatingDockContainer.cpp: line-ending false conflict (fork stores LF,
  upstream CRLF) re-merged content-wise; kept macOS escape-key polling,
  took upstream's Wayland ctor (isWayland() null-parent) + comment
- FloatingDragPreview.cpp: kept fork's dropOverlaysEnabled() early-out;
  adopted upstream's SourceContainer/Wayland container-picking loop

Validated: full build clean; QuadrantHitTestTest + OverlayGateTest pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@githubuser0xFFFF githubuser0xFFFF

Labels

under review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miskovoj @githubuser0xFFFF