Skip to content

feat: support fetch mr refs by libra#1070

Merged
genedna merged 1 commit into
gitmono-dev:mainfrom
benjamin-747:main
May 28, 2025
Merged

feat: support fetch mr refs by libra#1070
genedna merged 1 commit into
gitmono-dev:mainfrom
benjamin-747:main

Conversation

@benjamin-747

Copy link
Copy Markdown
Collaborator

No description provided.

@vercel

vercel Bot commented May 27, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 8:01am

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for fetching merge request (MR) references via Libra. Key changes include passing an additional listen_addr parameter to MonoApiService, updating branch filtering and reference updating in the Libra fetch command, and adjusting reference naming in utility functions and Docker build steps.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
mono/src/api/mr/mr_router.rs Passes listen_addr from state to the monorepo content_diff call
libra/src/command/fetch.rs Refactors branch filtering and updates branch reference handling for MR refs
docker/mono-engine-dockerfile Consolidates cargo build commands for mono and libra targets
common/src/utils.rs Updates MR reference naming from refs/heads to refs/mr
ceres/src/api_service/mono_api_service.rs Adjusts content_diff signature and replaces hard-coded listen address with a dynamic value

Comment thread mono/src/api/mr/mr_router.rs Outdated
Comment thread ceres/src/api_service/mono_api_service.rs Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for fetching merge request references by Libra. Key changes include:

  • Pass the listen_addr parameter to the monorepo content_diff function.
  • Update fetch logic in Libra to handle both branch and MR refs.
  • Modify Docker build commands, update mr_ref_name formatting, and add a new deploy workflow.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mono/src/api/mr/mr_router.rs Forward the new listen_addr parameter to content_diff.
libra/src/command/fetch.rs Adjust branch filtering and update ref processing to include MR ref handling and logging.
docker/mono-engine-dockerfile Combine cargo build commands for mono and libra with improved flag usage.
common/src/utils.rs Update mr_ref_name function to output "refs/mr/{mr_link}" instead of "refs/heads/{mr_link}".
ceres/src/api_service/mono_api_service.rs Update content_diff signature and modify Git remote and branch commands to use new MR ref names.
.github/workflows/mono-engine-deploy.yml Add a CI workflow for deploying the mono engine.

Comment thread .github/workflows/mono-engine-deploy.yml Outdated
@genedna
genedna added this pull request to the merge queue May 28, 2025
Merged via the queue into gitmono-dev:main with commit e35b5cd May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants