feat: support fetch mr refs by libra#1070
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for fetching merge request (MR) references via Libra. Key changes include passing an additional listen_addr parameter to MonoApiService, updating branch filtering and reference updating in the Libra fetch command, and adjusting reference naming in utility functions and Docker build steps.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mono/src/api/mr/mr_router.rs | Passes listen_addr from state to the monorepo content_diff call |
| libra/src/command/fetch.rs | Refactors branch filtering and updates branch reference handling for MR refs |
| docker/mono-engine-dockerfile | Consolidates cargo build commands for mono and libra targets |
| common/src/utils.rs | Updates MR reference naming from refs/heads to refs/mr |
| ceres/src/api_service/mono_api_service.rs | Adjusts content_diff signature and replaces hard-coded listen address with a dynamic value |
benjamin-747
marked this pull request as draft
May 28, 2025 03:07
benjamin-747
marked this pull request as ready for review
May 28, 2025 03:39
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for fetching merge request references by Libra. Key changes include:
- Pass the listen_addr parameter to the monorepo content_diff function.
- Update fetch logic in Libra to handle both branch and MR refs.
- Modify Docker build commands, update mr_ref_name formatting, and add a new deploy workflow.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mono/src/api/mr/mr_router.rs | Forward the new listen_addr parameter to content_diff. |
| libra/src/command/fetch.rs | Adjust branch filtering and update ref processing to include MR ref handling and logging. |
| docker/mono-engine-dockerfile | Combine cargo build commands for mono and libra with improved flag usage. |
| common/src/utils.rs | Update mr_ref_name function to output "refs/mr/{mr_link}" instead of "refs/heads/{mr_link}". |
| ceres/src/api_service/mono_api_service.rs | Update content_diff signature and modify Git remote and branch commands to use new MR ref names. |
| .github/workflows/mono-engine-deploy.yml | Add a CI workflow for deploying the mono engine. |
genedna
enabled auto-merge
May 28, 2025 09:00
genedna
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.