feat(UI): add issue pages#1076
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds issue tracking pages and related hooks, updates deployment configuration, and refines sidebar filtering.
- Introduces issue list/detail pages and new issue form with corresponding custom React Query hooks
- Adjusts Dockerfile and CI workflow for multi-stage builds
- Filters out null organizations in the sidebar switcher
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pages/[org]/mr/[id].tsx | Refactored imports, added usePostMrClose/usePostMrReopen hooks, adjusted conversation rendering |
| pages/[org]/issue/new/index.tsx | Added new issue creation route, but incorrectly reuses MRDetailPage |
| pages/[org]/issue/index.tsx | Added issue list page routing |
| pages/[org]/issue/[id]/index.tsx | Added issue detail SSR setup |
| hooks/issues/usePostIssueSubmit.ts | New hook for creating issues |
| hooks/issues/usePostIssueReopen.ts | New hook for reopening issues |
| hooks/issues/usePostIssueComment.ts | New hook for commenting on issues |
| hooks/issues/usePostIssueClose.ts | New hook for closing issues |
| hooks/issues/useGetIssueLists.ts | New hook for fetching issue lists |
| hooks/issues/useGetIssueDetail.ts | New hook for fetching issue details |
| hooks/issues/useDeleteIssueComment.ts | New hook for deleting issue comments |
| components/Sidebar/SidebarOrgSwitcher.tsx | Filters out null organizations before mapping |
| components/MrView/MRComment.tsx | Extended to handle both MR and issue comment deletion |
| components/Issues/MRDetailPage.tsx | New component for submitting a new issue |
| components/Issues/IssuePage.tsx | New component for listing issues |
| components/Issues/IssueDetailPage.tsx | New component for viewing and interacting with an issue |
| Dockerfile | Converted to multi-stage build |
| .github/workflows/web-deploy.yml | Commented out Next.js build step |
Comments suppressed due to low confidence (3)
moon/apps/web/components/MrView/MRComment.tsx:16
- [nitpick] The prop
whoamIis ambiguously cased and typed as a generic string. Consider renaming tocontextorrolewith a union type'mr' | 'issue'for clarity and type safety.
whoamI: string
.github/workflows/web-deploy.yml:62
- The Next.js build step is commented out in CI, which may skip your production build. Restore or update this step to ensure the application is built before deployment.
# # run: pnpm run build
moon/apps/web/pages/[org]/mr/[id].tsx:77
- The
approveMrcall placesrouter.push('/mr')directly in the options object instead of inside theonSuccesscallback. Ensurerouter.pushis nested underonSuccess: () => { ... }and remove the extraneous property.
router.push('/mr')
benjamin-747
requested changes
May 30, 2025
liuyangjuncong20202570
force-pushed
the
upstream
branch
from
May 30, 2025 04:08
6a8f645 to
a186dbd
Compare
liuyangjuncong20202570
force-pushed
the
upstream
branch
from
May 30, 2025 05:22
a186dbd to
f46f258
Compare
liuyangjuncong20202570
force-pushed
the
upstream
branch
from
May 30, 2025 05:34
f46f258 to
f2ed50c
Compare
liuyangjuncong20202570
force-pushed
the
upstream
branch
from
May 30, 2025 05:42
f2ed50c to
94203d9
Compare
liuyangjuncong20202570
force-pushed
the
upstream
branch
from
May 30, 2025 05:56
94203d9 to
334ebfa
Compare
liuyangjuncong20202570
force-pushed
the
upstream
branch
from
May 30, 2025 06:24
334ebfa to
4eeda44
Compare
benjamin-747
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
增加:
issue相关hooks
issue 页面组件
修改:
web-deploy.yml
Dockerfile
侧边栏过滤逻辑