Skip to content

feat(UI): add issue pages#1076

Merged
benjamin-747 merged 1 commit into
gitmono-dev:mainfrom
liuyangjuncong20202570:upstream
May 30, 2025
Merged

feat(UI): add issue pages#1076
benjamin-747 merged 1 commit into
gitmono-dev:mainfrom
liuyangjuncong20202570:upstream

Conversation

@liuyangjuncong20202570

Copy link
Copy Markdown
Contributor

增加:
issue相关hooks
issue 页面组件

修改:
web-deploy.yml
Dockerfile
侧边栏过滤逻辑

@vercel

vercel Bot commented May 29, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 6:26am

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds issue tracking pages and related hooks, updates deployment configuration, and refines sidebar filtering.

  • Introduces issue list/detail pages and new issue form with corresponding custom React Query hooks
  • Adjusts Dockerfile and CI workflow for multi-stage builds
  • Filters out null organizations in the sidebar switcher

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pages/[org]/mr/[id].tsx Refactored imports, added usePostMrClose/usePostMrReopen hooks, adjusted conversation rendering
pages/[org]/issue/new/index.tsx Added new issue creation route, but incorrectly reuses MRDetailPage
pages/[org]/issue/index.tsx Added issue list page routing
pages/[org]/issue/[id]/index.tsx Added issue detail SSR setup
hooks/issues/usePostIssueSubmit.ts New hook for creating issues
hooks/issues/usePostIssueReopen.ts New hook for reopening issues
hooks/issues/usePostIssueComment.ts New hook for commenting on issues
hooks/issues/usePostIssueClose.ts New hook for closing issues
hooks/issues/useGetIssueLists.ts New hook for fetching issue lists
hooks/issues/useGetIssueDetail.ts New hook for fetching issue details
hooks/issues/useDeleteIssueComment.ts New hook for deleting issue comments
components/Sidebar/SidebarOrgSwitcher.tsx Filters out null organizations before mapping
components/MrView/MRComment.tsx Extended to handle both MR and issue comment deletion
components/Issues/MRDetailPage.tsx New component for submitting a new issue
components/Issues/IssuePage.tsx New component for listing issues
components/Issues/IssueDetailPage.tsx New component for viewing and interacting with an issue
Dockerfile Converted to multi-stage build
.github/workflows/web-deploy.yml Commented out Next.js build step
Comments suppressed due to low confidence (3)

moon/apps/web/components/MrView/MRComment.tsx:16

  • [nitpick] The prop whoamI is ambiguously cased and typed as a generic string. Consider renaming to context or role with a union type 'mr' | 'issue' for clarity and type safety.
whoamI: string

.github/workflows/web-deploy.yml:62

  • The Next.js build step is commented out in CI, which may skip your production build. Restore or update this step to ensure the application is built before deployment.
#      #   run: pnpm run build

moon/apps/web/pages/[org]/mr/[id].tsx:77

  • The approveMr call places router.push('/mr') directly in the options object instead of inside the onSuccess callback. Ensure router.push is nested under onSuccess: () => { ... } and remove the extraneous property.
router.push('/mr')

Comment thread moon/apps/web/pages/[org]/issue/new/index.tsx Outdated
Comment thread moon/apps/web/components/Issues/MRDetailPage.tsx
Comment thread moon/pnpm-lock.yaml
Comment thread .github/workflows/web-deploy.yml Outdated
Comment thread moon/apps/web/components/Issues/MRDetailPage.tsx
@benjamin-747
benjamin-747 added this pull request to the merge queue May 30, 2025
Merged via the queue into gitmono-dev:main with commit 1731120 May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants