Skip to content

feat(UI): replace antd Icons to campsits'&add Icons story#1098

Merged
benjamin-747 merged 2 commits into
gitmono-dev:mainfrom
liuyangjuncong20202570:feat/Icon-change
Jun 6, 2025
Merged

feat(UI): replace antd Icons to campsits'&add Icons story#1098
benjamin-747 merged 2 commits into
gitmono-dev:mainfrom
liuyangjuncong20202570:feat/Icon-change

Conversation

@liuyangjuncong20202570

Copy link
Copy Markdown
Contributor

替换antd Icons(Code,MR,Issue)
增加Icons.stories.tsx用于预览
修改AttachmentGrid预览报错

@vercel

vercel Bot commented Jun 5, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 4:57pm

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces Ant Design icons with custom @gitmono/ui icons across the UI, adds a Storybook story to preview all icons, and updates code formatting and providers in related components.

  • Introduce Icons.stories.tsx for visualizing every icon in the @gitmono/ui library
  • Swap out CommentOutlined/CloseCircleOutlined and AntD copy/check icons for CanvasCommentIcon/ResolveCommentIcon, CopyIcon, DownloadIcon, and CheckIcon
  • Refactor import ordering, remove semicolons, and wrap stories with QueryNormalizerProvider

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Icons/Icons.stories.tsx Added new Storybook story to render all icons from index
IssueDetailPage.tsx Replaced AntD comment/close icons with CanvasCommentIcon/ResolveCommentIcon
RepoTree.tsx Reformatted imports and JSX, removed semicolons, normalized style
CloneTabs.tsx Swapped AntD copy/check icons for CopyIcon/CheckIcon, introduced snake_case state variables
.storybook/preview.tsx Wrapped stories with the new QueryNormalizerProvider
Comments suppressed due to low confidence (6)

moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:178

  • The appendTreeData function’s first branch has lost its return { ...item, children: subItems } due to misplaced braces. Restore the return inside this if block and correct the surrounding braces so the updated node is properly returned.
if (item.id === nodeId) {

moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:204

  • Another debug console.log that should be removed or replaced with proper error handling/logging.
console.log(node, 'node===node====')

moon/apps/web/components/CodeView/TreeView/CloneTabs.tsx:12

  • [nitpick] The state variable active_tab uses snake_case; conform to JavaScript/React conventions by renaming it to activeTab.
const [active_tab, setActiveTab] = useState<string>('1')

moon/apps/web/components/CodeView/TreeView/CloneTabs.tsx:36

  • [nitpick] The local constant tab_items should use camelCase (e.g., tabItems) to match project naming conventions.
const tab_items: TabsProps['items'] = [

moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:109

  • Leftover console.log statement likely used for debugging should be removed or replaced with a proper logging utility before production.
console.log(event, 'event===event====')

moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:197

  • Debug logging left in handleNodeToggle; consider removing this console.log or switching to a structured logger.
console.log('11111====')

@benjamin-747
benjamin-747 added this pull request to the merge queue Jun 6, 2025
Merged via the queue into gitmono-dev:main with commit f399e4a Jun 6, 2025
6 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Mega UI 重构 Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants