feat(UI): replace antd Icons to campsits'&add Icons story#1098
Merged
benjamin-747 merged 2 commits intoJun 6, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces Ant Design icons with custom @gitmono/ui icons across the UI, adds a Storybook story to preview all icons, and updates code formatting and providers in related components.
- Introduce
Icons.stories.tsxfor visualizing every icon in the@gitmono/uilibrary - Swap out
CommentOutlined/CloseCircleOutlinedand AntD copy/check icons forCanvasCommentIcon/ResolveCommentIcon,CopyIcon,DownloadIcon, andCheckIcon - Refactor import ordering, remove semicolons, and wrap stories with
QueryNormalizerProvider
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Icons/Icons.stories.tsx |
Added new Storybook story to render all icons from index |
IssueDetailPage.tsx |
Replaced AntD comment/close icons with CanvasCommentIcon/ResolveCommentIcon |
RepoTree.tsx |
Reformatted imports and JSX, removed semicolons, normalized style |
CloneTabs.tsx |
Swapped AntD copy/check icons for CopyIcon/CheckIcon, introduced snake_case state variables |
.storybook/preview.tsx |
Wrapped stories with the new QueryNormalizerProvider |
Comments suppressed due to low confidence (6)
moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:178
- The
appendTreeDatafunction’s first branch has lost itsreturn { ...item, children: subItems }due to misplaced braces. Restore the return inside thisifblock and correct the surrounding braces so the updated node is properly returned.
if (item.id === nodeId) {
moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:204
- Another debug
console.logthat should be removed or replaced with proper error handling/logging.
console.log(node, 'node===node====')
moon/apps/web/components/CodeView/TreeView/CloneTabs.tsx:12
- [nitpick] The state variable
active_tabuses snake_case; conform to JavaScript/React conventions by renaming it toactiveTab.
const [active_tab, setActiveTab] = useState<string>('1')
moon/apps/web/components/CodeView/TreeView/CloneTabs.tsx:36
- [nitpick] The local constant
tab_itemsshould use camelCase (e.g.,tabItems) to match project naming conventions.
const tab_items: TabsProps['items'] = [
moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:109
- Leftover
console.logstatement likely used for debugging should be removed or replaced with a proper logging utility before production.
console.log(event, 'event===event====')
moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:197
- Debug logging left in
handleNodeToggle; consider removing thisconsole.logor switching to a structured logger.
console.log('11111====')
benjamin-747
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
替换antd Icons(Code,MR,Issue)
增加Icons.stories.tsx用于预览
修改AttachmentGrid预览报错