refactor(UI):Display the data returned by the file-changed page in ch…#1109
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the UI to display file change diffs with a new diff view while replacing the previous Diff2Html-based implementation. Key changes include:
- Adding styles for the new diff view in _app.tsx.
- Replacing the Diff2Html and FilesChanged components with a new FileDiff component in the merge request page.
- Introducing new utility modules (parsedDiffs.ts and FileDiff.tsx) and updating dependencies in package.json.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| moon/apps/web/pages/_app.tsx | Added import for diff view CSS. |
| moon/apps/web/pages/[org]/mr/[id].tsx | Updated diff rendering logic and removed unused diff callback. |
| moon/apps/web/package.json | Added '@git-diff-view/react' dependency. |
| moon/apps/web/components/DiffView/parsedDiffs.ts | New module for parsing diff content with a regex approach. |
| moon/apps/web/components/DiffView/FileDiff.tsx | New FileDiff component for rendering diffs using the diff view library. |
Files not reviewed (1)
- moon/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
moon/apps/web/components/DiffView/FileDiff.tsx:5
- [nitpick] Consider importing 'cn' from the public API of '@gitmono/ui' instead of directly from the internal 'src/utils' to improve encapsulation and ensure long-term stability.
import { cn } from '@gitmono/ui/src/utils'
benjamin-747
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.