fix parse response from mono and add doc#1127
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the parsing of responses from Mono by refactoring from CommitInfo to TreeInfo structures and adds documentation and performance testing scripts.
- Refactored API response structures in dicfuse/store.rs
- Added a stub for get_oid_by_path in scorpio/src/scolfs/lfs.rs
- Included performance test scripts and documentation updates
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scorpio/src/scolfs/lfs.rs | Added stub function get_oid_by_path with a todo!() placeholder. |
| scorpio/src/dicfuse/store.rs | Renamed response structs from CommitInfo to TreeInfo; variable names unchanged. |
| scorpio/script/run.sh | Added a shell script for generating deep directory structures for testing. |
| scorpio/script/run.rs | Introduced a Rust-based performance test for file system access. |
| scorpio/doc/perf_test.md | Added documentation and test results for performance testing. |
| mercury/zstdelta/src/zstdelta.rs | Simplified decompression error string formatting. |
| mercury/delta/src/decode/mod.rs | Streamlined panic error messaging in delta decode errors. |
| mega/tests/service_test.rs | Reformatted test assertions for clarity. |
| jupiter/migration/src/m20250613_033821_alter_user_id.rs | Simplified SQLite migration code block. |
| common/src/config.rs | Reordered imports without changing functionality. |
Comments suppressed due to low confidence (2)
scorpio/src/dicfuse/store.rs:244
- [nitpick] The variable name 'commit_info' does not reflect its new type 'TreeInfoResponse'. Consider renaming it to 'tree_info' for improved clarity and consistency.
let commit_info: TreeInfoResponse = match response.json().await {
scorpio/src/scolfs/lfs.rs:185
- The stub function 'get_oid_by_path' uses a todo!() implementation which will panic if called. Consider either implementing the function or clearly marking it as a placeholder until a proper implementation is provided.
pub fn get_oid_by_path(_path: &str) -> String {
benjamin-747
approved these changes
Jun 17, 2025
Ivanbeethoven
approved these changes
Jun 17, 2025
genedna
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.修改scorpio处理mono响应的结构体变化
2.添加了记录fuse的性能测试,脚本和使用说明
3.cargo fmt和部分内容的clippy修复