Skip to content

fix parse response from mono and add doc#1127

Merged
genedna merged 1 commit into
gitmono-dev:mainfrom
yyjeqhc:fix_scorpio
Jun 17, 2025
Merged

fix parse response from mono and add doc#1127
genedna merged 1 commit into
gitmono-dev:mainfrom
yyjeqhc:fix_scorpio

Conversation

@yyjeqhc

@yyjeqhc yyjeqhc commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

1.修改scorpio处理mono响应的结构体变化
2.添加了记录fuse的性能测试,脚本和使用说明
3.cargo fmt和部分内容的clippy修复

@vercel

vercel Bot commented Jun 16, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 2:49pm

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the parsing of responses from Mono by refactoring from CommitInfo to TreeInfo structures and adds documentation and performance testing scripts.

  • Refactored API response structures in dicfuse/store.rs
  • Added a stub for get_oid_by_path in scorpio/src/scolfs/lfs.rs
  • Included performance test scripts and documentation updates

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scorpio/src/scolfs/lfs.rs Added stub function get_oid_by_path with a todo!() placeholder.
scorpio/src/dicfuse/store.rs Renamed response structs from CommitInfo to TreeInfo; variable names unchanged.
scorpio/script/run.sh Added a shell script for generating deep directory structures for testing.
scorpio/script/run.rs Introduced a Rust-based performance test for file system access.
scorpio/doc/perf_test.md Added documentation and test results for performance testing.
mercury/zstdelta/src/zstdelta.rs Simplified decompression error string formatting.
mercury/delta/src/decode/mod.rs Streamlined panic error messaging in delta decode errors.
mega/tests/service_test.rs Reformatted test assertions for clarity.
jupiter/migration/src/m20250613_033821_alter_user_id.rs Simplified SQLite migration code block.
common/src/config.rs Reordered imports without changing functionality.
Comments suppressed due to low confidence (2)

scorpio/src/dicfuse/store.rs:244

  • [nitpick] The variable name 'commit_info' does not reflect its new type 'TreeInfoResponse'. Consider renaming it to 'tree_info' for improved clarity and consistency.
let commit_info: TreeInfoResponse = match response.json().await {

scorpio/src/scolfs/lfs.rs:185

  • The stub function 'get_oid_by_path' uses a todo!() implementation which will panic if called. Consider either implementing the function or clearly marking it as a placeholder until a proper implementation is provided.
pub fn get_oid_by_path(_path: &str) -> String {

@genedna
genedna added this pull request to the merge queue Jun 17, 2025
Merged via the queue into gitmono-dev:main with commit 42fded8 Jun 17, 2025
14 checks passed
@yyjeqhc
yyjeqhc deleted the fix_scorpio branch June 18, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants