Skip to content

refactor(UI): The issue page editing box uses the tiptap component#1143

Merged
benjamin-747 merged 2 commits into
gitmono-dev:mainfrom
Ceron-CSS:issue-tiptap
Jun 20, 2025
Merged

refactor(UI): The issue page editing box uses the tiptap component#1143
benjamin-747 merged 2 commits into
gitmono-dev:mainfrom
Ceron-CSS:issue-tiptap

Conversation

@Ceron-CSS

Copy link
Copy Markdown
Contributor

1.On the new creation and detail pages of the issue, the rich text editor uses components encapsulated in tiptap and supports markdown syntax
2.Delete the file corresponding to the old text editor

@vercel

vercel Bot commented Jun 20, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 8:30am

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the old Lexical-based rich text editor in the issue creation and detail pages with a new tiptap-based SimpleNoteContent component, adds file attachment and reaction support, and removes the legacy editor code and styles.

  • Switches IssueNewPage and IssueDetailPage to use SimpleNoteContent, dropzone for attachments, and a reaction picker.
  • Deletes the entire MrView/rich-editor folder (CSS, plugins, themes, and components) and its license file.
  • Adds bottom-scroll handling and integrates markdown-supporting editor helpers.

Reviewed Changes

Copilot reviewed 11 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
moon/apps/web/components/SimpleNoteEditor/SimpleNoteContent.tsx Added bottom margin to the editor container
moon/apps/web/components/MrView/rich-editor/styles.css Removed legacy Lexical editor styles
moon/apps/web/components/MrView/rich-editor/plugins/TreeViewPlugin.tsx Deleted legacy TreeViewPlugin
moon/apps/web/components/MrView/rich-editor/plugins/ToolbarPlugin.tsx Deleted legacy ToolbarPlugin
moon/apps/web/components/MrView/rich-editor/icons/LICENSE.md Deleted icon license file
moon/apps/web/components/MrView/rich-editor/RichEditor.tsx Deleted legacy RichEditor component
moon/apps/web/components/MrView/rich-editor/LexicalContent.tsx Deleted legacy read-only LexicalContent component
moon/apps/web/components/MrView/rich-editor/ExampleTheme.ts Deleted legacy Lexical theme
moon/apps/web/components/MrView/files-changed.tsx Deleted legacy FilesChanged component
moon/apps/web/components/Issues/IssueNewPage.tsx Replaced RichEditor with SimpleNoteContent, file upload, picker
moon/apps/web/components/Issues/IssueDetailPage.tsx Replaced RichEditor with SimpleNoteContent, file upload, picker
Comments suppressed due to low confidence (3)

moon/apps/web/components/Issues/IssueNewPage.tsx:24

  • [nitpick] The function name set_to_loading uses snake_case, which is inconsistent with the project's camelCase convention. Consider renaming it to setToLoading for consistency.
  const set_to_loading = (index: number) => {

moon/apps/web/components/Issues/IssueNewPage.tsx:94

  • The integration of SimpleNoteContent with the dropzone file upload is not covered by tests. Consider adding unit or integration tests for comment submission with attachments to prevent regressions.
          <input {...dropzone.getInputProps()} />

moon/apps/web/components/Issues/IssueDetailPage.tsx:147

  • The function set_to_loading is not defined in this scope, which will cause a runtime error. It looks like you intended to use setLoading('comment', true) instead or remove this call.
      set_to_loading(3)

Comment thread moon/apps/web/components/Issues/IssueNewPage.tsx Outdated
@benjamin-747
benjamin-747 added this pull request to the merge queue Jun 20, 2025
Merged via the queue into gitmono-dev:main with commit 080eb3b Jun 20, 2025
5 checks passed
@Ceron-CSS
Ceron-CSS deleted the issue-tiptap branch June 25, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants