feat(libra/diff): support imara_diff v0.2.0 and add the extra param --algorithm of diff command#1146
Merged
Merged
Conversation
…-algorithm of diff command
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjamin-747
requested changes
Jun 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the imara_diff dependency to v0.2.0 and introduces an extra --algorithm parameter to allow selecting diff algorithms. Key changes include:
- Updating import paths and API calls to work with the new imara_diff version.
- Adding the --algorithm parameter in command-line arguments with associated tests.
- Updating dependency declarations in Cargo.toml and minor adjustments in config.rs.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libra/src/command/diff.rs | Modified diff command to support multiple algorithms and upgraded imara_diff API usage. |
| libra/Cargo.toml | Updated imara_diff dependency syntax to use workspace declaration for v0.2.0. |
| common/src/config.rs | Reordered use statements for consistency. |
| Cargo.toml | Upgraded imara_diff version from 0.1.8 to 0.2.0. |
genedna
approved these changes
Jun 23, 2025
genedna
enabled auto-merge
June 23, 2025 03:15
genedna
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #1142
imrama-diffto latest--algorithmparam to diff command to support multiple algorithm