refactor(UI):The timeline and tab components of the MR Page#1176
Merged
Conversation
Ceron-CSS
commented
Jul 1, 2025
Contributor
- Refactor timeline and Tabs using the primer library
- Comments support copying
- Dependencies are uniformly managed in pnpm-workspace.yaml
- Add loading effects in multiple places
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MR Page UI by replacing legacy components with Primer components and updating dependency management. Key changes include:
- Refactoring timeline and tab components to use UnderlinePanels and new TimelineItems.
- Updating TS configuration and dependency versions to use centralized catalog references.
- Adding loading effects and copyable comment support.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| moon/pnpm-workspace.yaml | Updates dependency versions and adds new dependencies for UI components. |
| moon/apps/web/tsconfig.json | Introduces nodenext settings to support module syntax. |
| moon/apps/web/pages/[org]/mr/[id].tsx | Refactors the MR Page layout with UnderlinePanels, TimelineItems, and updates to data loading handling. |
| moon/apps/web/package.json | Synchronizes dependency versions with the catalog. |
| moon/apps/web/components/MrView/TimelineItems.tsx | Introduces a new timeline component built with Primer components. |
| moon/apps/web/components/MrView/MRComment.tsx | Adds copyable text functionality in MR comments. |
| moon/apps/web/components/DiffView/FileDiff.tsx | Adjusts layout spacing with additional margin. |
Files not reviewed (1)
- moon/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
moon/apps/web/pages/[org]/mr/[id].tsx:93
- Removing the position configuration parameter for toast.error may change where the notification appears. Confirm that this change is intentional or consider restoring the previous configuration if the intended behavior is to display the error at the top-center.
toast.error('Please enter the content.')
moon/apps/web/pages/[org]/mr/[id].tsx:50
- [nitpick] Consider renaming 'detailIsLoading' and 'fileChgIsLoading' to more descriptive and consistent names (e.g., 'isMrDetailLoading' and 'isFilesChangedLoading') to improve readability.
const { data: MrDetailData, isLoading: detailIsLoading } = useGetMrDetail(id)
benjamin-747
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.