Skip to content

refactor(UI):The timeline and tab components of the MR Page#1176

Merged
benjamin-747 merged 2 commits into
gitmono-dev:mainfrom
Ceron-CSS:timeLine
Jul 1, 2025
Merged

refactor(UI):The timeline and tab components of the MR Page#1176
benjamin-747 merged 2 commits into
gitmono-dev:mainfrom
Ceron-CSS:timeLine

Conversation

@Ceron-CSS

Copy link
Copy Markdown
Contributor
  1. Refactor timeline and Tabs using the primer library
  2. Comments support copying
  3. Dependencies are uniformly managed in pnpm-workspace.yaml
  4. Add loading effects in multiple places

@vercel

vercel Bot commented Jul 1, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 8:56am

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the MR Page UI by replacing legacy components with Primer components and updating dependency management. Key changes include:

  • Refactoring timeline and tab components to use UnderlinePanels and new TimelineItems.
  • Updating TS configuration and dependency versions to use centralized catalog references.
  • Adding loading effects and copyable comment support.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
moon/pnpm-workspace.yaml Updates dependency versions and adds new dependencies for UI components.
moon/apps/web/tsconfig.json Introduces nodenext settings to support module syntax.
moon/apps/web/pages/[org]/mr/[id].tsx Refactors the MR Page layout with UnderlinePanels, TimelineItems, and updates to data loading handling.
moon/apps/web/package.json Synchronizes dependency versions with the catalog.
moon/apps/web/components/MrView/TimelineItems.tsx Introduces a new timeline component built with Primer components.
moon/apps/web/components/MrView/MRComment.tsx Adds copyable text functionality in MR comments.
moon/apps/web/components/DiffView/FileDiff.tsx Adjusts layout spacing with additional margin.
Files not reviewed (1)
  • moon/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

moon/apps/web/pages/[org]/mr/[id].tsx:93

  • Removing the position configuration parameter for toast.error may change where the notification appears. Confirm that this change is intentional or consider restoring the previous configuration if the intended behavior is to display the error at the top-center.
        toast.error('Please enter the content.')

moon/apps/web/pages/[org]/mr/[id].tsx:50

  • [nitpick] Consider renaming 'detailIsLoading' and 'fileChgIsLoading' to more descriptive and consistent names (e.g., 'isMrDetailLoading' and 'isFilesChangedLoading') to improve readability.
    const { data: MrDetailData, isLoading: detailIsLoading } = useGetMrDetail(id)

@benjamin-747
benjamin-747 added this pull request to the merge queue Jul 1, 2025
Merged via the queue into gitmono-dev:main with commit 5b18bc5 Jul 1, 2025
5 checks passed
@Ceron-CSS
Ceron-CSS deleted the timeLine branch July 7, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants