feat: Refactor the tree component, add a file type icon library, and …#1204
Merged
Conversation
…refactor the cloneTab.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the tree and table components to add dynamic loading, file-type icons, and improved clone UI, and wires path-change callbacks through the tree and code views.
- Introduces a
newPathstate andonCommitInfoChangecallbacks in tree and table pages - Replaces AntD popover/tabs with Radix UI components in
CloneTabs, adds skeletons in tables - Adds a
FileIconcomponent backed bymaterial-file-iconsand updates dependencies
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| moon/pnpm-workspace.yaml | Add material-file-icons dependency |
| moon/apps/web/pages/[org]/code/tree/[...path]/index.tsx | Use newPath state and pass onCommitInfoChange to child components |
| moon/apps/web/pages/[org]/code/blob/[...path].tsx | Remove redundant tree-fetch logic, simplify RepoTree usage |
| moon/apps/web/package.json | Add Radix context-menu/primitive and material-file-icons |
| moon/apps/web/components/CodeView/TreeView/RepoTree.tsx | Major rewrite for lazy-loading tree nodes and navigation callbacks |
| moon/apps/web/components/CodeView/TreeView/CloneTabs.tsx | Swap AntD popover/tabs for Radix UI, update styling |
| moon/apps/web/components/CodeView/Table/index.tsx | Add skeleton rows, memoize column config |
| moon/apps/web/components/CodeView/FileIcon/FileIcon.tsx | New FileIcon component using material-file-icons |
| moon/apps/web/components/CodeView/CodeTable.tsx | Integrate FileIcon, support path-change callbacks |
Files not reviewed (1)
- moon/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
moon/apps/web/components/CodeView/TreeView/CloneTabs.tsx:13
- [nitpick] The state variable
active_tabuses snake_case; rename it toactiveTabfor consistency with camelCase conventions.
const [active_tab, setActiveTab] = useState<string>('1')
moon/apps/web/components/CodeView/TreeView/RepoTree.tsx:153
- In the App Router context,
useRouter().queryisn't supported. UseuseParams()fromnext/navigationto access theorgroute parameter.
const scope = router.query.org as string;
| const directory: DirectoryType = useMemo(() => TreeCommitInfo?.data ?? [], [TreeCommitInfo]) | ||
| // const [newDirectory,setNewDirectory] = useState(directory) | ||
|
|
||
| const { data: canClone } = useGetTreePathCanClone({ path: new_path }) |
There was a problem hiding this comment.
The canClone hook still uses new_path instead of the updated newPath state, so it won't re-fetch when newPath changes. Update the argument to { path: newPath }.
Suggested change
| const { data: canClone } = useGetTreePathCanClone({ path: new_path }) | |
| const { data: canClone } = useGetTreePathCanClone({ path: newPath }) |
|
|
||
| type DirectoryType = NonNullable<CommonResultVecTreeCommitItem['data']> | ||
| const directory: DirectoryType = useMemo(() => TreeCommitInfo?.data ?? [], [TreeCommitInfo]) | ||
| // const [newDirectory,setNewDirectory] = useState(directory) |
There was a problem hiding this comment.
[nitpick] This commented-out state is no longer used and can be removed to keep the code clean.
Suggested change
| // const [newDirectory,setNewDirectory] = useState(directory) |
| const pathname = usePathname() | ||
| const [text, setText] = useState<string>(pathname || '') | ||
| const [copied, setCopied] = useState<boolean>(false) | ||
| const [active_tab, setActiveTab] = useState<string>('1') |
There was a problem hiding this comment.
The default value '1' doesn't match the 'HTTP' and 'SSH' tab values, so the initial active tab styling is incorrect. Change it to useState<string>('HTTP').
Suggested change
| const [active_tab, setActiveTab] = useState<string>('1') | |
| const [active_tab, setActiveTab] = useState<string>('HTTP') |
benjamin-747
approved these changes
Jul 8, 2025
yyk808
pushed a commit
to yyk808/mega
that referenced
this pull request
Jul 9, 2025
gitmono-dev#1204) * feat: Refactor the tree component, add a file type icon library, and refactor the cloneTab. * fix: fix eslint * fix: fix eslint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…refactor the cloneTab.