refactor(UI):Comment Display Card#1206
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the MR and issue detail pages to use a new comment card design, adds a “Checks” tab, and extracts reusable UI components for timeline items and timestamps.
- Adds a “Checks” tab with its icon in the MR detail view
- Extends conversation data with
usernameandupdated_at, updating hooks and page types - Extracts
HandleTime,UserLinkByName, and action-specific timeline item components (CloseItem,ReopenItem,MergedItem)
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pages/[org]/mr/[id].tsx | Added “Checks” tab, ChecklistIcon, updated Conversation fields, and moved UnderlinePanels require |
| hooks/issues/useGetIssueDetail.ts | Updated conversations interface to include updated_at and username |
| components/MrView/components/UserLinkByName.tsx | New component for linking usernames |
| components/MrView/components/HandleTime.tsx | New timestamp formatter with tooltip |
| components/MrView/TimelineItems.tsx | Switched to CloseItem/ReopenItem/MergedItem, replaced icons |
| components/MrView/ReopenItem.tsx | New timeline item for reopen actions |
| components/MrView/CloseItem.tsx | New timeline item for close actions |
| components/MrView/MergedItem.tsx | New timeline item for merge actions |
| components/MrView/MRComment.tsx | Refactored comment card UI, removed antd |
| components/Issues/IssueDetailPage.tsx | Aligned issue detail conversation fields with MR changes |
Comments suppressed due to low confidence (3)
moon/apps/web/hooks/issues/useGetIssueDetail.ts:5
- [nitpick] Type names should be PascalCase. Rename the
conversationsinterface toConversationto follow conventions.
interface conversations {
moon/apps/web/components/MrView/CloseItem.tsx:1
- [nitpick]
CloseItemandReopenItemshare identical structure except for props. Consider abstracting common layout into a single component to reduce duplication.
import { ConditionalWrap } from '@gitmono/ui'
moon/apps/web/pages/[org]/mr/[id].tsx:212
- The “Checks” panel currently contains only placeholder text. Add the actual checks content or a TODO comment to clarify future work.
<div>Checks</div>
genedna
approved these changes
Jul 8, 2025
yyk808
pushed a commit
to yyk808/mega
that referenced
this pull request
Jul 9, 2025
Co-authored-by: Quanyi Ma <eli@patch.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.