Skip to content

Monobean: fix distribution issue on macOS#1211

Merged
genedna merged 3 commits into
gitmono-dev:mainfrom
yyk808:main
Jul 10, 2025
Merged

Monobean: fix distribution issue on macOS#1211
genedna merged 3 commits into
gitmono-dev:mainfrom
yyk808:main

Conversation

@yyk808

@yyk808 yyk808 commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator

This pull request updates the packaging configuration for the monobean project on macOS, focusing on dependency management and resource inclusion. The changes improve compatibility and ensure all required libraries and frameworks are properly bundled.

Packaging configuration updates:

  • Updated the before-packaging-command to use a custom script (fix_macos_deps.sh) for refreshing dependencies, patching dylibs, and setting the appropriate runtime path (@executable_path/../Frameworks).
  • Replaced outdated resources (lib/bin/*.dll, lib/bin/gdbus.exe) with patched dynamic libraries for gdk-pixbuf loaders, ensuring compatibility with macOS.
  • Added a comprehensive list of patched macOS frameworks (e.g., libadwaita-1.0.dylib, libgtk-4.1.dylib, libssl.3.dylib) to the macos section to ensure all runtime dependencies are included.

Description refinement:

  • Simplified the project description by removing Monero-specific references, emphasizing its role as a GUI tool for managing monorepo code.

Copilot AI review requested due to automatic review settings July 9, 2025 14:29
@vercel

vercel Bot commented Jul 9, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2025 7:05am

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the macOS packaging setup for Monobean by updating the packager configuration to use a custom dependency-fixing script and ensuring all required dynamic libraries and frameworks are bundled correctly.

  • Switch to fix_macos_deps.sh for pre-packaging dependency refresh and rpath patching
  • Replace Windows-specific resources with patched gdk-pixbuf loaders and add full macOS framework list
  • Simplify project description and add the new dependency-fixing shell script

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
monobean/resources/packager_aarch64-apple-darwin.toml Update before-packaging-command, resource list, description, and add frameworks array
monobean/resources/fix_macos_deps.sh Add the custom script to locate, patch, and bundle macOS dylibs and fix linkages
Comments suppressed due to low confidence (3)

monobean/resources/packager_aarch64-apple-darwin.toml:8

  • [nitpick] The usage header in the script references binary_dylib_tool but the file is named fix_macos_deps.sh. Update the command name to match the script file for clarity.
binaries_dir = "../target/release"

monobean/resources/fix_macos_deps.sh:1

  • The script uses Bash-specific array syntax (e.g., all_binaries=()) but the shebang is /bin/sh. Change the shebang to #!/usr/bin/env bash or rewrite the arrays to be POSIX-compliant.
#!/bin/sh

monobean/resources/fix_macos_deps.sh:176

  • OLDIFS isn't saved in the main() function before modifying IFS, so restoring it may have no effect or introduce unexpected behavior. Consider saving OLDIFS immediately before any IFS change or remove this restore if unnecessary.
    IFS=$OLDIFS

@genedna
genedna added this pull request to the merge queue Jul 10, 2025
Merged via the queue into gitmono-dev:main with commit 5e9f4a2 Jul 10, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants