Monobean: fix distribution issue on macOS#1211
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the macOS packaging setup for Monobean by updating the packager configuration to use a custom dependency-fixing script and ensuring all required dynamic libraries and frameworks are bundled correctly.
- Switch to
fix_macos_deps.shfor pre-packaging dependency refresh and rpath patching - Replace Windows-specific resources with patched
gdk-pixbufloaders and add full macOS framework list - Simplify project description and add the new dependency-fixing shell script
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| monobean/resources/packager_aarch64-apple-darwin.toml | Update before-packaging-command, resource list, description, and add frameworks array |
| monobean/resources/fix_macos_deps.sh | Add the custom script to locate, patch, and bundle macOS dylibs and fix linkages |
Comments suppressed due to low confidence (3)
monobean/resources/packager_aarch64-apple-darwin.toml:8
- [nitpick] The usage header in the script references
binary_dylib_toolbut the file is namedfix_macos_deps.sh. Update the command name to match the script file for clarity.
binaries_dir = "../target/release"
monobean/resources/fix_macos_deps.sh:1
- The script uses Bash-specific array syntax (e.g.,
all_binaries=()) but the shebang is/bin/sh. Change the shebang to#!/usr/bin/env bashor rewrite the arrays to be POSIX-compliant.
#!/bin/sh
monobean/resources/fix_macos_deps.sh:176
OLDIFSisn't saved in themain()function before modifyingIFS, so restoring it may have no effect or introduce unexpected behavior. Consider savingOLDIFSimmediately before any IFS change or remove this restore if unnecessary.
IFS=$OLDIFS
genedna
enabled auto-merge
July 10, 2025 07:20
genedna
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the packaging configuration for the
monobeanproject on macOS, focusing on dependency management and resource inclusion. The changes improve compatibility and ensure all required libraries and frameworks are properly bundled.Packaging configuration updates:
before-packaging-commandto use a custom script (fix_macos_deps.sh) for refreshing dependencies, patching dylibs, and setting the appropriate runtime path (@executable_path/../Frameworks).lib/bin/*.dll,lib/bin/gdbus.exe) with patched dynamic libraries forgdk-pixbufloaders, ensuring compatibility with macOS.libadwaita-1.0.dylib,libgtk-4.1.dylib,libssl.3.dylib) to themacossection to ensure all runtime dependencies are included.Description refinement: