fix(monobean unittest): deadlock in launching http and ssh#1222
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to resolve a deadlock in the test_launch_ssh unit test by removing the custom single-worker Tokio test configuration and falling back to the default runtime settings.
- Removed the explicit
flavor = "multi_thread", worker_threads = 1annotation - Let the Tokio macro use its default thread pool size
Comments suppressed due to low confidence (1)
monobean/src/core/mega_core.rs:544
- [nitpick] Removing the explicit Tokio test configuration may lead to inconsistent thread usage across different environments. Consider specifying a worker_threads count (e.g.,
worker_threads = 2) or adding a comment to explain why the default settings prevent the deadlock.
#[tokio::test]
genedna
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.