[mercury]:Annotations and minor refactoring of Git objects #1225
Merged
Conversation
Signed-off-by: Han Xiaoyang <lux1an@qq.com>
Signed-off-by: Xiaoyang Han <lux1an@qq.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds annotations, documentation, and minor refactorings around Git object types and model conversions.
- Introduces
From<mega_commit::Model>andFrom<git_commit::Model>conversions in theCommittype - Adds doc comments and cleans up constructors in
Bloband SHA1 hashing - Removes duplicate model-to-
Commitimpls and tidies imports in the internal model layer
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| mercury/src/internal/object/commit.rs | Added #[non_exhaustive], docs for from_tree_id, and From<…Model> impls |
| mercury/src/internal/object/blob.rs | Added docs for from_content, removed dead code, and annotated hash calculation |
| mercury/src/internal/model/commit.rs | Removed redundant From<…Model> impls and cleaned up import formatting |
| mercury/src/hash.rs | Documented the from_type_and_data SHA1 construction algorithm |
Comments suppressed due to low confidence (1)
mercury/src/hash.rs:105
- [nitpick] This doc line uses non-standard punctuation and formatting, which can be confusing. Consider rewriting it with standard parentheses and clearer wording, e.g.,
Hash = “<type> <length>\0<content>”.
/// Hash compute <- {Object Type}+{ }+{Object Size(before compress)}+{\x00}+{Object Content(before compress)}
Signed-off-by: Han Xiaoyang <lux1an@qq.com>
genedna
enabled auto-merge
July 15, 2025 01:15
genedna
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.