feat(UI):Comment support emoji interaction and comment addition menus#1236
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds emoji reaction support and comment management functionality to both MR (merge request) and issue views. The changes create a unified conversation system that supports reactions and dropdown menus for comments.
- Migrates from custom
Conversationinterface to generatedConversationItemtype for better type safety - Adds emoji reaction functionality with support for adding/removing reactions on comments
- Implements dropdown menus for comment actions (copy, quote, edit, delete, etc.)
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| moon/apps/web/styles/global.css | Adds CSS styles for improved focus states and popup elements |
| moon/apps/web/pages/[org]/mr/[id].tsx | Updates MR detail interface and removes custom Conversation type |
| moon/apps/web/hooks/issues/useGetIssueDetail.ts | Standardizes query key usage for better cache management |
| moon/apps/web/hooks/conversation/usePostConversationReactions.ts | New hook for adding reactions to comments |
| moon/apps/web/hooks/conversation/useDeleteConversationReaction.ts | New hook for removing reactions from comments |
| moon/apps/web/components/Reactions/ReactionShow.tsx | New component for displaying and managing comment reactions |
| moon/apps/web/components/MrView/hook/useHandleExpression.ts | New hook for handling reaction add/remove logic |
| moon/apps/web/components/MrView/TimelineItems.tsx | Refactors to support both MR and issue types with generic detail prop |
| moon/apps/web/components/MrView/ReopenItem.tsx | Updates to use ConversationItem type |
| moon/apps/web/components/MrView/MergedItem.tsx | Updates to use ConversationItem type |
| moon/apps/web/components/MrView/MRComment.tsx | Adds reaction picker, dropdown menu, and reaction display |
| moon/apps/web/components/MrView/CommentDropdownMenu.tsx | New dropdown menu component for comment actions |
| moon/apps/web/components/MrView/CloseItem.tsx | Updates to use ConversationItem type |
| moon/apps/web/components/Issues/IssueDetailPage.tsx | Updates to use unified TimelineItems component |
Comments suppressed due to low confidence (2)
moon/apps/web/components/MrView/CommentDropdownMenu.tsx:10
- The prop name 'Conversation' uses PascalCase which is unconventional for React props. Consider renaming to 'conversation' to follow camelCase naming conventions.
Conversation: ConversationItem
moon/apps/web/components/MrView/CommentDropdownMenu.tsx:11
- The prop name 'CommentType' uses PascalCase which is unconventional for React props. Consider renaming to 'commentType' to follow camelCase naming conventions.
CommentType: 'mr' | 'issue' | (string & {})
benjamin-747
enabled auto-merge
July 16, 2025 07:14
benjamin-747
approved these changes
Jul 16, 2025
liuyangjuncong20202570
pushed a commit
to liuyangjuncong20202570/mega
that referenced
this pull request
Jul 20, 2025
…gitmono-dev#1236) * feat(UI):Comment support emoji interaction and comment addition menus * fix(UI):fix TypeScript's type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.