feat: moon add note sync services#1282
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds note sync services to the mono application by implementing note storage functionality in Jupiter and creating REST API endpoints for note synchronization. The changes also include database migration for notes table and regenerated entity files from SeaORM codegen.
- Adds note storage layer in Jupiter with CRUD operations for notes
- Implements REST API endpoints for retrieving and updating note sync state
- Creates database migration to add the notes table with proper indexing
Reviewed Changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| mono/src/server/https_server.rs | Adds SYNC_NOTES_STATE_TAG constant for API documentation |
| mono/src/api/notes/note_router.rs | Implements REST endpoints for note sync state (show/update) |
| mono/src/api/notes/model.rs | Defines request/response models for note API |
| mono/src/api/mod.rs | Integrates note storage into the main API service state |
| mono/src/api/api_router.rs | Registers note router with the main API router |
| jupiter/src/storage/note_storage.rs | Implements note storage layer with database operations |
| jupiter/src/storage/mod.rs | Integrates note storage into the storage service |
| jupiter/src/migration/m20250725_103004_add_note.rs | Database migration to create notes table with indexes |
| jupiter/callisto/src/notes.rs | Generated SeaORM entity for notes table |
| jupiter/callisto/* | Updated generated files from SeaORM codegen 1.1.14 |
| } | ||
|
|
||
| #[utoipa::path( | ||
| get, |
There was a problem hiding this comment.
The API path includes {org_slug} parameter but the function doesn't extract or validate it. This could lead to confusion about which organization the note belongs to.
| ) -> Result<Json<ShowResponse>, ApiError> { | ||
| let note = state.note_stg().get_note_by_id(id.into()).await?; | ||
| if note.is_none() { | ||
| return Err(ApiError::from(anyhow::anyhow!("Note not found"))); |
There was a problem hiding this comment.
The error message "Note not found" should be more specific and include the note ID for better debugging.
Suggested change
| return Err(ApiError::from(anyhow::anyhow!("Note not found"))); | |
| return Err(ApiError::from(anyhow::anyhow!(format!("Note not found with ID: {}", id)))); |
benjamin-747
requested changes
Jul 29, 2025
…, enrich error messages
benjamin-747
requested changes
Jul 31, 2025
Collaborator
|
link #1184 |
benjamin-747
approved these changes
Jul 31, 2025
benjamin-747
enabled auto-merge
July 31, 2025 11:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generated.tsand move it to moon