feat(UI):Support force-push type, loading position adjustment#1302
Merged
Conversation
Ceron-CSS
commented
Aug 2, 2025
Contributor
- Support force-push type
- loading position adjustment
- code display for new file types
…de display for new file types
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for force-push events in the timeline view, adjusts loading spinner positioning, removes autofocus from an editor, and adds support for new file extensions in the diff viewer.
- Adds ForcePushItem component to handle force-push timeline events
- Improves loading spinner positioning with better centering and height constraints
- Adds support for workspace, .buckroot, and .buckconfig file types in diff view
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| moon/apps/web/pages/[org]/mr/[link]/[id].tsx | Adjusts loading spinner positioning and removes editor autofocus |
| moon/apps/web/components/MrView/item/ForcePushItem.tsx | Creates new component for displaying force-push timeline events |
| moon/apps/web/components/MrView/TimelineItems.tsx | Integrates ForcePushItem component into timeline switch statement |
| moon/apps/web/components/MrView/MergedItem.tsx | Adds user avatar and hover card functionality to merged events |
| moon/apps/web/components/DiffView/parsedDiffs.ts | Extends file extension mapping for new file types |
Comments suppressed due to low confidence (3)
moon/apps/web/components/MrView/item/ForcePushItem.tsx:5
- The interface name 'ReopenItemProps' should be 'ForcePushItemProps' to match the component's purpose.
interface ReopenItemProps {
moon/apps/web/components/MrView/item/ForcePushItem.tsx:8
- The component name 'ReopenItem' should be 'ForcePushItem' to match the filename and purpose.
const ReopenItem = ({ conv }: ReopenItemProps) => {
moon/apps/web/components/MrView/item/ForcePushItem.tsx:22
- The exported component name should be 'ForcePushItem' instead of 'ReopenItem' to match the filename and intended functionality.
export default ReopenItem
benjamin-747
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.