feat:fix the router problem & add assignees style#1303
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liuyangjuncong20202570
force-pushed
the
feat-lyjc
branch
from
August 2, 2025 08:55
a689ce6 to
7867be4
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes router issues by simplifying URL structure and adds assignee styling components for issue/MR timeline views.
- Removes ID parameter from router URLs, using only link parameter and storing ID in Jotai state
- Adds new AssigneeItem component for displaying assignee changes in timeline
- Updates router navigation to use state management instead of URL parameters
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
moon/apps/web/pages/[org]/mr/[link]/index.tsx |
Updates router to use link-only URLs and adds atom state management |
moon/apps/web/pages/[org]/issue/[link]/index.tsx |
Removes ID parameter from server-side props and component interface |
moon/apps/web/components/MrView/index.tsx |
Updates MR item navigation to store ID in state and use simplified URLs |
moon/apps/web/components/MrView/TimelineItems.tsx |
Adds AssigneeItem component for timeline display with PersonIcon |
moon/apps/web/components/MrView/ReopenItem.tsx |
Exports interface for reuse in AssigneeItem component |
moon/apps/web/components/MrView/AssigneeItem.tsx |
New component for displaying assignee changes with user avatars and links |
moon/apps/web/components/Issues/utils/store.tsx |
Adds new atoms for ID state management |
moon/apps/web/components/Issues/IssuesContent.tsx |
Updates issue navigation to use state management and simplified URLs |
moon/apps/web/components/Issues/IssueDetailPage.tsx |
Refactors to use ID from atom state instead of props |
Comments suppressed due to low confidence (2)
moon/apps/web/components/MrView/AssigneeItem.tsx:11
- The component uses
ReopenItemPropsinterface for an assignee component, which is misleading and creates incorrect type coupling. Consider creating a dedicatedAssigneeItemPropsinterface.
const AssigneeItem = ({ conv }: ReopenItemProps) => {
moon/apps/web/components/Issues/utils/store.tsx:43
- [nitpick] The variable name
idAtomis ambiguous and could refer to any type of ID. Consider renaming toissueIdAtomto match the pattern used bymridAtom.
export const idAtom = atom(0)
benjamin-747
approved these changes
Aug 4, 2025
liuyangjuncong20202570
force-pushed
the
feat-lyjc
branch
from
August 4, 2025 02:52
1ae719a to
c8e968a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改路由显示只显示link
增加Assigness显示组件