Fix monobean setup.py#1323
Merged
Merged
Conversation
Signed-off-by: Quanyi Ma <eli@patch.sh>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ivanbeethoven
approved these changes
Aug 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the setup.py file in the monobean package by uncommenting code that fetches the latest GTK release version dynamically from GitHub, though the hardcoded download URL remains unchanged.
- Uncomments variables for fetching the latest GTK release tag from GitHub
- Restores dynamic version detection functionality that was previously commented out
| # GTK_PKG = "https://github.com/wingtk/gvsbuild/releases/latest" | ||
| # gtk_ver = get_redirected_url(GTK_PKG).split("/")[-1] | ||
| GTK_PKG = "https://github.com/wingtk/gvsbuild/releases/latest" | ||
| gtk_ver = get_redirected_url(GTK_PKG).split("/")[-1] |
There was a problem hiding this comment.
The get_redirected_url function can return None on error, but this code attempts to call .split() on the result without checking for None first, which will cause an AttributeError.
Suggested change
| gtk_ver = get_redirected_url(GTK_PKG).split("/")[-1] | |
| redirected_url = get_redirected_url(GTK_PKG) | |
| if redirected_url is None: | |
| print("Failed to retrieve the redirected URL for the latest GTK4 release.") | |
| exit(1) | |
| gtk_ver = redirected_url.split("/")[-1] |
| # GTK_PKG = "https://github.com/wingtk/gvsbuild/releases/latest" | ||
| # gtk_ver = get_redirected_url(GTK_PKG).split("/")[-1] | ||
| GTK_PKG = "https://github.com/wingtk/gvsbuild/releases/latest" | ||
| gtk_ver = get_redirected_url(GTK_PKG).split("/")[-1] |
There was a problem hiding this comment.
The gtk_ver variable is assigned but never used since the hardcoded gtk_url on line 93 doesn't reference it. This creates dead code that fetches a value unnecessarily.
Signed-off-by: Quanyi Ma <eli@patch.sh>
Signed-off-by: Quanyi Ma <eli@patch.sh>
Signed-off-by: Quanyi Ma <eli@patch.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.