feat: add cors config for orion#1377
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
Adds CORS (Cross-Origin Resource Sharing) configuration to the Orion server to allow cross-origin requests from specified domains. This enables the server to be accessed by web applications running on different origins.
- Configures CORS middleware with environment-variable driven allowed origins
- Adds support for common HTTP methods and headers including credentials
- Updates dependencies to include required CORS functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| orion-server/src/server.rs | Implements CORS middleware configuration with environment-based origin allowlist |
| orion-server/Cargo.toml | Adds required dependencies for CORS and HTTP functionality |
| orion-server/.env | Defines allowed CORS origins for local and production environments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| let origins: Vec<HeaderValue> = std::env::var("ALLOWED_CORS_ORIGINS") | ||
| .unwrap() | ||
| .split(',') | ||
| .map(|x| x.trim().parse::<HeaderValue>().unwrap()) | ||
| .collect(); |
There was a problem hiding this comment.
The code will panic if the ALLOWED_CORS_ORIGINS environment variable is not set or if any origin cannot be parsed as a HeaderValue. Consider using proper error handling with expect() or unwrap_or_default() and handling parse errors gracefully.
| let origins: Vec<HeaderValue> = std::env::var("ALLOWED_CORS_ORIGINS") | |
| .unwrap() | |
| .split(',') | |
| .map(|x| x.trim().parse::<HeaderValue>().unwrap()) | |
| .collect(); | |
| let origins: Vec<HeaderValue> = match std::env::var("ALLOWED_CORS_ORIGINS") { | |
| Ok(val) => val | |
| .split(',') | |
| .filter_map(|x| { | |
| let trimmed = x.trim(); | |
| match HeaderValue::from_str(trimmed) { | |
| Ok(hv) => Some(hv), | |
| Err(e) => { | |
| tracing::warn!("Invalid CORS origin '{}': {}", trimmed, e); | |
| None | |
| } | |
| } | |
| }) | |
| .collect(), | |
| Err(e) => { | |
| tracing::error!("ALLOWED_CORS_ORIGINS environment variable is not set: {}", e); | |
| std::process::exit(1); | |
| } | |
| }; |
| PORT=80 | ||
| MONOBASE_URL="http://git.gitmega.com" No newline at end of file | ||
| MONOBASE_URL="http://git.gitmega.com" | ||
| ALLOWED_CORS_ORIGINS = "http://local.gitmega.com, https://app.gitmega.com, http://app.gitmono.test" No newline at end of file |
There was a problem hiding this comment.
Environment variable assignments should not have spaces around the equals sign. Change to ALLOWED_CORS_ORIGINS=\"http://local.gitmega.com, https://app.gitmega.com, http://app.gitmono.test\"
| ALLOWED_CORS_ORIGINS = "http://local.gitmega.com, https://app.gitmega.com, http://app.gitmono.test" | |
| ALLOWED_CORS_ORIGINS="http://local.gitmega.com, https://app.gitmega.com, http://app.gitmono.test" |
No description provided.