Gpg API

[AidCheng]

Removed dependency on Sequoia-openpgp
Provided:

1. Add
2. List
3. Delete

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
mega	Ready	Preview	Comment	Aug 27, 2025 1:52am

[Copilot]

Pull Request Overview

This PR implements a GPG key management API by removing the dependency on Sequoia-openpgp and adding functionality for adding, listing, and deleting GPG keys. The implementation includes database migrations, API endpoints, and signature verification capabilities.

• Added complete GPG key management system with database models and storage layer
• Implemented API endpoints for adding, listing, and deleting GPG keys
• Added GPG signature verification for merge requests

Reviewed Changes

Copilot reviewed 42 out of 43 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
orion-server/src/model/builds.rs	Removed empty line for formatting
orion-server/src/api.rs	Reformatted long method chains for better readability
mono/src/server/http_server.rs	Added GPG API tag constant
mono/src/api/mr/mr_router.rs	Added MR signature verification endpoint
mono/src/api/gpg/	New GPG module with router, models, and API endpoints
mono/src/api/mod.rs	Integrated GPG storage and module
jupiter/src/storage/	Added GPG storage implementation
jupiter/src/migration/	Added GPG key database table migration
jupiter/callisto/src/gpg_key.rs	Added GPG key entity model
libra/src/	Formatting improvements and code organization
ceres/src/api_service/mono_api_service.rs	Added GPG signature verification logic
config files	Updated dependencies and configuration

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The error from remove_gpg_key is being ignored with let _. This could mask important failures. Consider handling the error appropriately or returning it to the caller.

Suggested change

	let _ = state
	.gpg_stg()
	.remove_gpg_key(req.user_id, req.key_id)
	.await;
	state
	.gpg_stg()
	.remove_gpg_key(req.user_id, req.key_id)
	.await?;

[Copilot]

The error from add_gpg_key is being ignored with let _. This could mask important failures. Consider handling the error appropriately or returning it to the caller.

Suggested change

	let _ = state
	.gpg_stg()
	.add_gpg_key(req.user_id, req.gpg_content, req.expires_days)
	.await;
	state
	.gpg_stg()
	.add_gpg_key(req.user_id, req.gpg_content, req.expires_days)
	.await?;

[Copilot]

Using {:?} for fingerprint formatting may include debug formatting artifacts. Consider using a more appropriate format specifier or method that produces the expected fingerprint format.

[Copilot]

This code will panic if find_user_by_email returns None. The unwrap() after the await? should be replaced with proper error handling that returns an appropriate error instead of panicking.

Suggested change

	.storage
	.user_storage()
	.find_user_by_email(&self.extract_email(&content).await.unwrap_or_default())
	.await?
	.unwrap()
	.ok_or_else(|| MegaError::with_message("User not found for commit email"))?

[Copilot]

Creating a new Regex instance on every call is inefficient. Consider using a static regex or lazy_static to compile the regex once and reuse it.