feat: implement commit-user binding by 231220075 · Pull Request #1420 · gitmono-dev/mega

231220075 · 2025-09-08T03:35:45Z

Backend Implementation

Database Schema: Added commit_auths table to store commit-user associations
Storage Layer: Implemented CommitBindingStorage trait with upsert and query capabilities
Authentication: Added UserAuthExtractor for identity extraction from AccessToken
API Endpoints:
- GET /api/v1/commits/{sha}/binding - Query commit binding information
- PUT /api/v1/commits/{sha}/binding - Create/update commit bindings

Frontend Integration

React Hook: useGetCommitBinding with React Query for efficient data fetching
UI Components: Enhanced CommitHistory and CommitMessageWithAuthor to display user info
User Experience: Added avatars, verification badges, and anonymous commit indicators

…st version) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn> feat(commit-message-binding):finish binding commit-message to user (2st version) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn> feat: implement commit-user binding Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

vercel · 2025-09-08T03:35:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
mega	Ready	Preview	Comment	Sep 10, 2025 0:15am

genedna · 2025-09-08T08:47:14Z

+    queryKey: ['commit-binding', sha],
+    queryFn: async (): Promise<CommitBindingData> => {
+      const baseUrl = process.env.NEXT_PUBLIC_MONO_API_URL || process.env.NEXT_PUBLIC_API_URL || 'http://localhost:8000'
+      const url = `${baseUrl}/api/v1/mega/commits/${sha}`


@231220075 ，

这里的 URL 和在描述里面写的不一致：

API Endpoints: GET /api/v1/commits/{sha}/binding - Query commit binding information PUT /api/v1/commits/{sha}/binding - Create/update commit bindings

benjamin-747 · 2025-09-08T08:55:40Z

API 请求由swagger 文档直接生成，不建议自己实现

…ev#1409) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

Signed-off-by: Ruizhi Huang <166112492+231220075@users.noreply.github.com>

Copilot

Pull Request Overview

This PR implements commit-user binding functionality to associate Git commits with authenticated users, enabling better user tracking and attribution in the system.

Added database schema for storing commit-user associations with authentication status
Implemented storage layer with upsert and query capabilities for commit bindings
Created API endpoints for retrieving and updating commit binding information

Reviewed Changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
mono/src/api/commit/	New API module with models and router for commit binding endpoints
mono/src/api/api_router.rs	Integration of commit router into main API
jupiter/src/storage/	Database storage implementation and migration for commit_auths table
ceres/src/protocol/smart.rs	Git protocol integration for automatic binding during push operations
ceres/src/auth/mod.rs	User authentication extraction framework for Git operations
docs/	Updated documentation for database schema and API endpoints

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-10T08:02:30Z

+    commit_binding_storage::CommitBindingStorage, conversation_storage::ConversationStorage,
+    git_db_storage::GitDbStorage, issue_storage::IssueStorage, lfs_db_storage::LfsDbStorage,
+    mr_reviewer_storage::MrReviewerStorage, mono_storage::MonoStorage, mr_storage::MrStorage, 
+    raw_db_storage::RawDbStorage,relay_storage::RelayStorage, user_storage::UserStorage, 


Missing space after comma between raw_db_storage::RawDbStorage and relay_storage::RelayStorage.

Suggested change

raw_db_storage::RawDbStorage,relay_storage::RelayStorage, user_storage::UserStorage,

raw_db_storage::RawDbStorage, relay_storage::RelayStorage, user_storage::UserStorage,

Copilot · 2025-09-10T08:02:31Z

+                    Some(UserInfo {
+                        id: user.id.to_string(),
+                        username: user.name.clone(),
+                        display_name: Some(user.name.clone()), // Use name as display_name since display_name field doesn't exist


The comment indicates that display_name field doesn't exist, but the code is setting it to Some(user.name.clone()). This comment should be updated to clarify the actual behavior or the field should be properly implemented.

Suggested change

display_name: Some(user.name.clone()), // Use name as display_name since display_name field doesn't exist

display_name: Some(user.name.clone()), // Use name as display_name (fallback if no separate display name is available)

Copilot · 2025-09-10T08:02:31Z

+                )
+            } else {
+                // Fallback for cases where user is matched but user info is not available
+                (binding_model.author_email.split('@').next().unwrap_or(&binding_model.author_email).to_string(), None, false)


This line is overly complex and hard to read. Consider extracting the email parsing logic into a separate function for better maintainability.

Copilot · 2025-09-10T08:02:31Z

+                        let matched_user = user_storage.find_user_by_email(&author_email).await?;
+
+                        if let Some(user) = matched_user {
+                            (Some(user.id.to_string()), false)


The code is using user.id.to_string() but should be using user.name.clone() to match the matched_username field which expects a username string, not a user ID.

Copilot · 2025-09-10T08:02:31Z

+                    let matched_user = user_storage.find_user_by_email(&author_email).await?;
+
+                    if let Some(user) = matched_user {
+                        (Some(user.id.to_string()), false)


Similar to the previous comment, these lines are using user.id.to_string() but should be using user.name.clone() to match the expected username format for the matched_username field.

Copilot · 2025-09-10T08:02:32Z

+            let matched_user = user_storage.find_user_by_email(&author_email).await?;
+
+            if let Some(user) = matched_user {
+                (Some(user.id.to_string()), false)


Similar to the previous comment, these lines are using user.id.to_string() but should be using user.name.clone() to match the expected username format for the matched_username field.

Copilot · 2025-09-10T08:02:32Z

+                            if let Ok(commit_obj) = mercury::internal::object::commit::Commit::from_bytes(&entry.data, entry.hash) {
+                                let mut commits = commits_to_process.lock().unwrap();
+                                commits.push((commit_obj.id.to_string(), commit_obj.author.email.clone()));
+                            }


Parsing commit objects twice (once here and potentially again in the storage layer) is inefficient. Consider reusing the parsed commit object or restructuring to avoid duplicate parsing.

Suggested change

if let Ok(commit_obj) = mercury::internal::object::commit::Commit::from_bytes(&entry.data, entry.hash) {

let mut commits = commits_to_process.lock().unwrap();

commits.push((commit_obj.id.to_string(), commit_obj.author.email.clone()));

}

let mut commits = commits_to_process.lock().unwrap();

commits.push((commit.id.to_string(), commit.author.email.clone()));

…ev#1409) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn> fix bugs in ceres/src/protocol/smart.rs Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

vercel Bot deployed to Preview September 8, 2025 03:36 View deployment

benjamin-747 requested review from benjamin-747 and genedna September 8, 2025 06:49

benjamin-747 assigned 231220075 Sep 8, 2025

genedna requested a review from Copilot September 8, 2025 08:25

This comment was marked as outdated.

Sign in to view

genedna reviewed Sep 8, 2025

View reviewed changes

benjamin-747 requested changes Sep 8, 2025

View reviewed changes

feat: implement commit-user binding and fix problems (issue gitmono-d…

10b0e61

…ev#1409) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

vercel Bot deployed to Preview September 10, 2025 07:11 View deployment

Merge branch 'main' into feat/commit-user-binding

de68a24

Signed-off-by: Ruizhi Huang <166112492+231220075@users.noreply.github.com>

vercel Bot deployed to Preview September 10, 2025 07:27 View deployment

genedna requested a review from Copilot September 10, 2025 08:00

Merge branch 'main' into feat/commit-user-binding

e7717ff

Signed-off-by: Ruizhi Huang <166112492+231220075@users.noreply.github.com>

Copilot AI reviewed Sep 10, 2025

View reviewed changes

vercel Bot deployed to Preview September 10, 2025 08:04 View deployment

benjamin-747 reviewed Sep 10, 2025

View reviewed changes

Comment thread gateway/src/https_server.rs Outdated

Merge branch 'main' into feat/commit-user-binding

ce6189b

vercel Bot deployed to Preview September 10, 2025 09:09 View deployment

benjamin-747 approved these changes Sep 10, 2025

View reviewed changes

feat: implement commit-user binding and fix problems (issue gitmono-d…

0578014

…ev#1409) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn> fix bugs in ceres/src/protocol/smart.rs Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

vercel Bot deployed to Preview September 10, 2025 12:15 View deployment

genedna added this pull request to the merge queue Sep 10, 2025

Merged via the queue into gitmono-dev:main with commit 53585b6 Sep 10, 2025
13 checks passed

	raw_db_storage::RawDbStorage,relay_storage::RelayStorage, user_storage::UserStorage,
	raw_db_storage::RawDbStorage, relay_storage::RelayStorage, user_storage::UserStorage,

	display_name: Some(user.name.clone()), // Use name as display_name since display_name field doesn't exist
	display_name: Some(user.name.clone()), // Use name as display_name (fallback if no separate display name is available)

Uh oh!

Conversation

231220075 commented Sep 8, 2025

Backend Implementation

Frontend Integration

Uh oh!

vercel Bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

genedna Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benjamin-747 Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel Bot commented Sep 8, 2025 •

edited

Loading