Feat/commit user binding by 231220075 · Pull Request #1434 · gitmono-dev/mega

231220075 · 2025-09-11T03:41:32Z

Addition: merge GET commit-binding API into GET latest-commit API

Add CommitBindingInfo to LatestCommitInfo response structure.
Move GET functionality from commit binding endpoint to latest-commit.
Simplify commit binding router to focus on PUT operations only.

…st version) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn> feat(commit-message-binding):finish binding commit-message to user (2st version) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn> feat: implement commit-user binding Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

…ev#1409) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

Signed-off-by: Ruizhi Huang <166112492+231220075@users.noreply.github.com>

…ev#1409) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn> fix bugs in ceres/src/protocol/smart.rs Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

vercel · 2025-09-11T03:41:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
mega	Ready	Preview	Comment	Sep 11, 2025 11:30am

Copilot

Pull Request Overview

This PR consolidates commit binding functionality by merging the GET commit-binding API into the GET latest-commit API and simplifying the commit router to handle only PUT operations.

Key changes:

Added CommitBindingInfo to LatestCommitInfo response structure
Moved GET commit binding functionality from dedicated endpoint to latest-commit endpoint
Removed GET route from commit router, keeping only PUT operations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
mono/src/api/commit/commit_router.rs	Removed GET endpoint and its implementation, simplified router to PUT operations only
mono/src/api/api_router.rs	Enhanced get_latest_commit to include commit binding information in response
docs/api.md	Updated documentation to reflect removal of GET commit binding endpoint
ceres/src/model/git.rs	Added CommitBindingInfo struct and integrated it into LatestCommitInfo

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-11T04:20:01Z

        request.is_anonymous,
    ).await
    .map_err(|e| ApiError::from(anyhow::anyhow!("Failed to update binding: {}", e)))?;
+


Remove the trailing whitespace on line 81.

Suggested change

Copilot · 2025-09-11T04:20:01Z

-    get_commit_binding(State(state), Path(sha)).await
+    // Return success response with complete information
+    Ok(Json(CommonResult::success(Some(CommitBindingResponse {
+        binding: None, // Could optionally include updated binding details


The binding field is hardcoded to None with a comment suggesting it could include details. This creates an inconsistent API response compared to the latest-commit endpoint. Consider either populating this field with the actual binding data or removing the misleading comment.

Copilot · 2025-09-11T04:20:01Z

    let query_path: std::path::PathBuf = query.path.into();
-    let import_dir = state.storage.config().monorepo.import_dir.clone();
-    if let Ok(rest) = query_path.strip_prefix(import_dir) {
+    let import_dir = state.storage.config().monorepo.import_dir.clone(); 


Remove the trailing whitespace at the end of line 128.

Suggested change

let import_dir = state.storage.config().monorepo.import_dir.clone();

let import_dir = state.storage.config().monorepo.import_dir.clone();

Copilot · 2025-09-11T04:20:02Z

+    let mut commit_info = if let Ok(rest) = query_path.strip_prefix(import_dir) {
        if rest.components().count() == 1 {
            let res = state
                .monorepo()
                .get_latest_commit(query_path.clone())
                .await?;
-            return Ok(Json(res));
+            res
+        } else {
+            let res = state
+                .api_handler(&query_path)
+                .await?
+                .get_latest_commit(query_path)
+                .await?;
+            res
        }
+    } else {
+        let res = state
+            .api_handler(&query_path)
+            .await?
+            .get_latest_commit(query_path)
+            .await?;
+        res
+    };


There's duplicated code in the else branch (lines 137-142 and 145-149). Consider extracting this common logic into a helper function or variable to reduce duplication.

benjamin-747 · 2025-09-11T09:13:59Z

+    let commit_binding_storage = state.storage.commit_binding_storage();
+    let user_storage = state.storage.user_storage();
+
+    if let Ok(Some(binding_model)) = commit_binding_storage.find_by_sha(&commit_info.oid).await {


请将具体的逻辑转移到service 层处理，router 只保留接口转发功能

…ion from router to service layer Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

Signed-off-by: Ruizhi Huang <166112492+231220075@users.noreply.github.com>

Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

…into feat/commit-user-binding

Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

231220075 and others added 7 commits September 8, 2025 11:29

feat: implement commit-user binding and fix problems (issue gitmono-d…

10b0e61

…ev#1409) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

Merge branch 'main' into feat/commit-user-binding

de68a24

Signed-off-by: Ruizhi Huang <166112492+231220075@users.noreply.github.com>

Merge branch 'main' into feat/commit-user-binding

e7717ff

Signed-off-by: Ruizhi Huang <166112492+231220075@users.noreply.github.com>

Merge branch 'main' into feat/commit-user-binding

ce6189b

feat: implement commit-user binding and fix problems (issue gitmono-d…

0578014

…ev#1409) Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn> fix bugs in ceres/src/protocol/smart.rs Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

refactor: merge GET commit-binding into GET latest-commit

2325318

Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

vercel Bot deployed to Preview September 11, 2025 03:42 View deployment

vercel Bot deployed to Preview September 11, 2025 04:06 View deployment

genedna requested review from benjamin-747 and Copilot September 11, 2025 04:19

Copilot AI reviewed Sep 11, 2025

View reviewed changes

vercel Bot deployed to Preview September 11, 2025 07:30 View deployment

231220075 force-pushed the feat/commit-user-binding branch from 524f8f2 to ced258b Compare September 11, 2025 07:37

vercel Bot deployed to Preview September 11, 2025 07:38 View deployment

vercel Bot deployed to Preview September 11, 2025 07:42 View deployment

benjamin-747 requested changes Sep 11, 2025

View reviewed changes

231220075 force-pushed the feat/commit-user-binding branch from 62daf00 to 21dd83b Compare September 11, 2025 10:15

vercel Bot deployed to Preview September 11, 2025 10:16 View deployment

vercel Bot deployed to Preview September 11, 2025 10:35 View deployment

refactor: format code to standards and move commit-user binding funct…

145cf46

…ion from router to service layer Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

231220075 force-pushed the feat/commit-user-binding branch from 9e3a6ad to 145cf46 Compare September 11, 2025 10:51

vercel Bot deployed to Preview September 11, 2025 10:53 View deployment

Merge branch 'main' into feat/commit-user-binding

ba010e3

Signed-off-by: Ruizhi Huang <166112492+231220075@users.noreply.github.com>

vercel Bot deployed to Preview September 11, 2025 10:59 View deployment

231220075 added 2 commits September 11, 2025 19:14

fix: fix mutiple define

e580058

Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

Merge branch 'feat/commit-user-binding' of github.com:231220075/mega …

292dcf1

…into feat/commit-user-binding

vercel Bot deployed to Preview September 11, 2025 11:17 View deployment

fix: fix missing imports

9a88c44

Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>

vercel Bot deployed to Preview September 11, 2025 11:30 View deployment

benjamin-747 approved these changes Sep 11, 2025

View reviewed changes

benjamin-747 added this pull request to the merge queue Sep 11, 2025

Merged via the queue into gitmono-dev:main with commit 053536e Sep 11, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/commit user binding#1434

Feat/commit user binding#1434
benjamin-747 merged 12 commits into
gitmono-dev:mainfrom
231220075:feat/commit-user-binding

231220075 commented Sep 11, 2025

Uh oh!

vercel Bot commented Sep 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

benjamin-747 Sep 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	let import_dir = state.storage.config().monorepo.import_dir.clone();
	let import_dir = state.storage.config().monorepo.import_dir.clone();

Uh oh!

Conversation

231220075 commented Sep 11, 2025

Uh oh!

vercel Bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

benjamin-747 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Sep 11, 2025 •

edited

Loading