Resolvable reviews

[AidCheng]

Summary

This pull request introduces key improvements to the reviewer and review conversation system in the MR workflow:

• Refactored reviewer schema – Switched to mr_link and username; added timestamps.
• Added review resolution state – Introduced a resolved field for tracking conversation status.
• Updated reviewer logic – Normalized storage and methods around mr_link.
• Improved API consistency – Aligned endpoints and payloads with the new data model.
• Enhanced review comment flow – Automatically tags reviewer comments as Review.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
mega	Ready	Preview	Comment	Sep 12, 2025 7:39pm

[Copilot]

Pull Request Overview

This PR refactors the reviewer and review conversation system to improve the MR workflow by transitioning from ID-based to link-based operations and adding review resolution capabilities.

Key changes:

• Refactored reviewer schema to use mr_link and username instead of mr_id and campsite_id
• Added review resolution state tracking with a resolved field in conversations
• Enhanced review comment flow to automatically tag reviewer comments as Review type

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
mono/src/api/mr/mr_router.rs	Updated API endpoints to use new reviewer schema and added review resolution endpoint
mono/src/api/mr/model.rs	Modified payload structures to align with new data model
jupiter/src/storage/mr_reviewer_storage.rs	Refactored storage methods to use mr_link and username parameters
jupiter/src/storage/conversation_storage.rs	Added review resolution state management functionality
jupiter/src/migration/m20250910_153212_add_username_to_reviewer.rs	Database migration for schema changes
jupiter/callisto/src/mega_mr_reviewer.rs	Updated entity model with new fields
jupiter/callisto/src/mega_conversation.rs	Added resolved field to conversation model
jupiter/callisto/src/entity_ext/mega_conversation.rs	Enhanced conversation creation with resolution state
ceres/src/merge_checker/code_review_checker.rs	Updated to use new reviewer storage interface

Comments suppressed due to low confidence (1)

ceres/src/merge_checker/code_review_checker.rs:69

• The code references reviewer.id but the new reviewer model uses username field. This should be reviewer.username.

                let msg = format!("Reviewer {} has not approved the MR.\n", reviewer.id);

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Duplicate #[async_trait::async_trait] attribute should be removed. Only one instance is needed.

Suggested change

#[async_trait::async_trait]

[Copilot]

The is_reviewer method always returns Ok(true) regardless of whether a reviewer is found. It should return Ok(reviewer.is_some()) to correctly indicate if the user is a reviewer.

[Copilot]

[nitpick] Extra blank line between error message and closing bracket should be removed for consistency.

Suggested change