Skip to content

fix Libra p2p download: path error #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genedna merged 3 commits into from
Nov 9, 2024
Merged

fix Libra p2p download: path error #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e62761f
fix: GitLFSError ignore content
Hou-Xiaoxuan Nov 8, 2024
de23af6
fix: create parent dirs for `path` in `download_object_p2p`
MrBeanCpp Nov 8, 2024
1d91262
Merge branch 'refs/heads/main' into fix-libra-p2p
MrBeanCpp Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions common/src/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,8 @@ impl From<sea_orm::DbErr> for MegaError {
}

#[derive(Error, Debug)]
#[allow(unused)]
pub enum GitLFSError {
#[error("Something went wrong in Git LFS")]
#[error("Something went wrong in Git LFS: {0}")]
GeneralError(String),
}

Expand Down
3 changes: 3 additions & 0 deletions libra/src/internal/protocol/lfs_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@ impl LFSClient {
// infer that all chunks share same size! (except last one)
let chunk_size = chunks.first().unwrap().size as usize;
let mut checksum = Context::new(&SHA256);
if let Some(parent) = path.as_ref().parent() {
tokio::fs::create_dir_all(parent).await?;
}
let mut file = tokio::fs::File::create(path).await?;
for (i, chunk) in chunks.iter().enumerate() { // TODO parallel download
println!("- part: {}/{}", i + 1, chunks.len());
Expand Down