refactor(mercury): remove sha1_smol dependency#739
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
mercury/src/hash.rs:66
- The error message should be more descriptive. Consider changing it to: 'Invalid input length: expected a 40-character SHA-1 hash string.'
return Err("The length of the string is not 40".to_string());
mercury/src/hash.rs:101
- Ensure that the behavior of sha1::Sha1::digest is covered by tests.
let h = sha1::Sha1::digest(data);
genedna
enabled auto-merge
December 12, 2024 14:01
genedna
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two different SHA1 implementations (i.e.
sha1andsha1_smol) and a custom SHA1 Wrapper exist simultaneously in the codebase, which doesn't make sense.Since
sha1is more widely used across the project, it should be kept in favor ofsha1_smol.