Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 20 additions & 28 deletions common/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,34 +62,26 @@ pub fn format_commit_msg(msg: &str, gpg_sig: Option<&str>) -> String {
}

/// parse commit message
pub fn parse_commit_msg(msg_gpg: &str) -> (String, Option<String>) {
const GPG_SIG_START: &str = "gpgsig -----BEGIN PGP SIGNATURE-----";
const GPG_SIG_END: &str = "-----END PGP SIGNATURE-----";
let gpg_start = msg_gpg.find(GPG_SIG_START);
let gpg_end = msg_gpg.find(GPG_SIG_END).map(|end| end + GPG_SIG_END.len());
let gpg_sig = match (gpg_start, gpg_end) {
(Some(start), Some(end)) => {
if start < end {
Some(msg_gpg[start..end].to_string())
} else {
None
}
}
_ => None,
};
match gpg_sig {
Some(gpg) => {
// Skip the leading '\n\n' (blank lines).
// Some commit messages may use '\n \n\n' or similar patterns.
// To handle such cases, remove all leading blank lines from the message.
let msg = msg_gpg[gpg_end.unwrap()..].trim_start().to_string();
(msg, Some(gpg))
}
None => {
assert!(msg_gpg.starts_with('\n'), "commit message format error");
let msg = msg_gpg[1..].to_string(); // skip the leading '\n' (blank line)
(msg, None)
}
pub fn parse_commit_msg(msg_gpg: &str) -> (&str, Option<&str>) {
const SIG_PATTERN: &str = r"^(gpgsig -----BEGIN (?:PGP|SSH) SIGNATURE-----[\s\S]*?-----END (?:PGP|SSH) SIGNATURE-----)";
let sig_regex = Regex::new(SIG_PATTERN).unwrap();
if let Some(caps) = sig_regex.captures(msg_gpg) {
// Check if the signature type matches.
assert_eq!(
caps.get(2).map(|m| m.as_str()),
caps.get(3).map(|m| m.as_str())
);
let sig_len = caps.get(1).map(|m| m.as_str().len()).unwrap();
let signature = &msg_gpg[..sig_len];

// Skip the leading '\n\n' (blank lines).
// Some commit messages may use '\n \n\n' or similar patterns.
// To handle such cases, remove all leading blank lines from the message.
let msg = &msg_gpg[sig_len..].trim_start();
(msg, Some(signature))
} else {
assert!(msg_gpg.starts_with('\n'), "commit message format error");
(&msg_gpg[1..], None)
}
}

Expand Down
12 changes: 9 additions & 3 deletions libra/src/command/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,21 @@ mod test {
let msg = "commit message";
let gpg_sig =
"gpgsig -----BEGIN PGP SIGNATURE-----\ncontent\n-----END PGP SIGNATURE-----";
let ssh_sig =
"gpgsig -----BEGIN SSH SIGNATURE-----\ncontent1\n-----END SSH SIGNATURE-----";
let msg_gpg = format_commit_msg(msg, Some(gpg_sig));
let msg_ssh = format_commit_msg(msg, Some(ssh_sig));
let (msg_, gpg_sig_) = parse_commit_msg(&msg_gpg);
let (msg__, ssh_sig__) = parse_commit_msg(&msg_ssh);
assert_eq!(msg, msg_);
assert_eq!(msg, msg__);
assert_eq!(gpg_sig, gpg_sig_.unwrap());
assert_eq!(ssh_sig, ssh_sig__.unwrap());

let msg_gpg = format_commit_msg(msg, None);
let (msg_, gpg_sig_) = parse_commit_msg(&msg_gpg);
let msg_none = format_commit_msg(msg, None);
let (msg_, sig_) = parse_commit_msg(&msg_none);
assert_eq!(msg, msg_);
assert_eq!(None, gpg_sig_);
assert_eq!(None, sig_);
}

{
Expand Down