refactor(mercury): fix incorrect equality checks, remove unused attri…#754
Merged
Conversation
…butes and improve enum derive traits
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
el-ev
marked this pull request as draft
December 14, 2024 08:19
Contributor
Author
|
"Sorry for the confusion," it appears that some "uncessary derives" are actually used... |
el-ev
marked this pull request as ready for review
December 14, 2024 08:32
genedna
enabled auto-merge
December 14, 2024 11:11
genedna
approved these changes
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…butes and improve enum derive traits
Closes #748 .
PartialEqimplementation forCommit,BlobandTag.#[allow(unused)]attributes, they were once used for supressing warnings but are no longer necessary now.Ord,PartialOrdfor enumerations that are never meant to be compared.