ci(release): release libra binary and monobean installer for windows_x64,linux_x86_64 and macos_aarch64#998
Merged
Merged
Conversation
This commit adds support for the --amend flag in the commit command, allowing users to amend the previous commit instead of creating a new one. This feature enhances the CLI by enabling more flexible version history management, especially useful when users want to fix typos or update commit messages without generating extra commits. and modify the docs --amend only support when the commit has only a parent commit.
Signed-off-by: Quanyi Ma <eli@patch.sh>
Signed-off-by: Quanyi Ma <eli@patch.sh>
Signed-off-by: Eli Ma <eli@patch.sh>
Signed-off-by: Quanyi Ma <eli@patch.sh>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release workflows, installer configurations, and application logging to support a multi-platform release of the Monobean application while enhancing dependency setup and packaging logic. Key changes include:
- Refined platform checks and caching conditions in install and workflow scripts.
- Improved logging setup in the application and updated resource loading logic.
- Updated packaging configuration files for Linux, Windows, and macOS.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| monobean/src/main.rs | Updates resource loading logic with a fallback path. |
| monobean/src/application.rs | Modifies logging configuration with conditional setup for debug/release. |
| monobean/setup.py | Integrates an upgrade flag via argparse and refines setup behaviors. |
| monobean/resources/*.toml | Adds configuration files for platform-specific packaging. |
| monobean/Cargo.toml | Updates dependencies and removes release profile LTO configuration. |
| .github/workflows/release.yml | Revises release workflow to support semantic version tags and packaging. |
| .github/workflows/base.yml | Adjusts workflow triggers for the release job. |
| .github/install-dep/action.yml | Updates platform condition checks using broader matching. |
Files not reviewed (1)
- monobean/resources/gtk/hello_page.ui: Language not supported
Comments suppressed due to low confidence (2)
monobean/Cargo.toml:47
- Removal of the 'lto = "fat"' configuration in the release profile may lead to less optimized builds; please confirm if this change is intentional.
-[profile.release]
.github/workflows/release.yml:52
- [nitpick] Ensure consistency in naming conventions for the packaged binaries across platforms; the use of double underscores here contrasts with naming in other steps.
mv monobean/target/build/monobean__${{ matrix.arch }}.deb ${{ github.workspace }}/Monobean_${{ github.ref_name }}_${{ matrix.target }}.deb
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
genedna
enabled auto-merge
May 1, 2025 05:08
genedna
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across multiple areas, including platform-specific installation logic, release workflow enhancements, dependency and logging improvements, and user interface updates for the Monobean application. The most significant changes include making platform checks more flexible, refining the release workflows, and adding new features like logging to file and GTK4 version upgrades.
TLDR;
windows_x64,linux_x86_64andmacos_aarch64.Known bugs
makepkg. However, the same script works on Arch Linux host machine.0.0.1, or we can't locate its package name in github workflows.Platform-specific Installation Logic Updates:
.github/install-dep/action.ymlto use thecontainsfunction for broader matching of platform names, replacing exact equality checks. [1] [2] [3] [4] [5]Release Workflow Enhancements:
.github/workflows/release.ymlto handle semantic versioning tags (v*.*.*) and added architecture-specific packaging for Linux, macOS, and Windows usingcargo-packager. Removed thecreate-releasejob and replaced binary upload steps with platform-specific preparation and release steps. [1] [2]packager_x86_64-unknown-linux-gnu.toml,packager_aarch64-apple-darwin.toml,packager_x86_64-pc-windows-msvc.toml) for generating platform-specific installers. [1] [2] [3]