feat(translations): add Spanish translations #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandronanez
requested review from
Antoine38660,
SammyIsra,
andrewda,
housseindjirdeh and
patw0929
SammyIsra
reviewed
Sep 2, 2017
| "Welcome! This is your news feed - it'll help you keep up with recent activity on repositories you watch and people you follow.", | ||
| commitCommentEvent: 'commented on commit', | ||
| createEvent: 'creado {{object}}', | ||
| deleteEvent: 'borrado {{object}}', |
Member
There was a problem hiding this comment.
Shouldn't these two lines be {{object}} creado and {{object}} borrado?
Member
Author
There was a problem hiding this comment.
Makes perfect sense! IDK what I was thinking lol
Member
|
Thanks for putting this PR up @alejandronanez. Even if it's a work in progress, I like having a discussion for it earlier rather than later :) It really looks like it's coming together nicely 😍 |
andrewda
changed the title
Closed
This was referenced Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, guys! This is the initial work for the Spanish translations, it's just a few lines but it's something.
Thanks!
Closes #233