Skip to content

Conversation

@pixelead0
Copy link

@pixelead0 pixelead0 commented Oct 12, 2017

Refs #439

Edited by lex111: we must not close issue #439, because not all translations are exists, and this issue will be open throughout October, while Hacktoberfest passes.

@tautf
Copy link
Contributor

tautf commented Oct 12, 2017

@pixelead0 Thank you very much!

But shouldn’t that be es in line 1?

contact2:
'If you have any questions about this Privacy Policy or GitPoint in general, please file an issue in the',
contactLink: 'GitPoint repository',
"If you have any questions about this Privacy Policy or GitPoint in general, please file an issue in the",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed to remove this line.

Because of this, the travis build fails.

@lex111
Copy link
Member

lex111 commented Oct 13, 2017

@pixelead0 thank you for your work, but we already have PR for translating into Spanish - #442 . Could you check it?

@andrewda andrewda changed the title #439 spanish translation fix(translation): fix spanish translation Oct 13, 2017
@pixelead0
Copy link
Author

How can I change or merge the es.js file from pr # 442?

@lex111
Copy link
Member

lex111 commented Oct 13, 2017

@pixelead0 You can not do this, just leave a comment there if need to correct the translation.

@alejandronanez
Copy link
Member

I think we should wait for #422 before merging this one.
Thoughts @lex111 @FlorianTaut @housseindjirdeh @andrewda

@lex111
Copy link
Member

lex111 commented Oct 13, 2017

@alejandronanez but is there any point in merging this PR?

@alejandronanez
Copy link
Member

@lex111 actually we have two PRs with almost the same content. What about merging #422 and then see if this one is still relevant?

@lex111
Copy link
Member

lex111 commented Oct 13, 2017

@alejandronanez 👌

@itsfreddyrb
Copy link

I don't get it. I've checked the es file and there's many, many strings yet to be translated, and found some syntax improvements to be done. Is this being done or is it a finished file? Thanks.

@alejandronanez
Copy link
Member

@GeekFred we already have a PR open before this one with spanish translations #442 we should wait for that PR to get merged first and then see if this one is still relevant.

@itsfreddyrb
Copy link

Excellent!

@housseindjirdeh
Copy link
Member

@pixelead0 Thanks so much for this. #442 should be merged in soon and I would love if we can cross check any remaining/fixable translations after that's in. Can't tell you much how we appreciate you taking the time to put this PR up 🙌

@pixelead0
Copy link
Author

I resolved conflicts with #442

@housseindjirdeh
Copy link
Member

@pixelead0 thank you <3

Did you rebase from latest master because it still seems like a few conflicts are present. Could you take a look whenever you get the chance 🙏

@machour
Copy link
Member

machour commented Jan 16, 2018

Hola @pixelead0 !

Spanish translations have been merged a while ago:
https://github.com/gitpoint/git-point/blob/master/src/locale/languages/es.js

Could you give them a review and tell us if there are still changes to be made? 🙏

@machour
Copy link
Member

machour commented Apr 26, 2018

Hi there. Our translations files structure completely changed. I'm going to close this PR for now.
Feel free to open a new PR with fixes, #442 have been merged since then.

Thank you again for all your hard work!

@machour machour closed this Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants