-
Notifications
You must be signed in to change notification settings - Fork 778
fix(translation): fix spanish translation #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pixelead0 Thank you very much! But shouldn’t that be |
src/locale/languages/es.js
Outdated
| contact2: | ||
| 'If you have any questions about this Privacy Policy or GitPoint in general, please file an issue in the', | ||
| contactLink: 'GitPoint repository', | ||
| "If you have any questions about this Privacy Policy or GitPoint in general, please file an issue in the", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed to remove this line.
Because of this, the travis build fails.
|
@pixelead0 thank you for your work, but we already have PR for translating into Spanish - #442 . Could you check it? |
|
How can I change or merge the es.js file from pr # 442? |
|
@pixelead0 You can not do this, just leave a comment there if need to correct the translation. |
|
I think we should wait for #422 before merging this one. |
|
@alejandronanez but is there any point in merging this PR? |
|
I don't get it. I've checked the es file and there's many, many strings yet to be translated, and found some syntax improvements to be done. Is this being done or is it a finished file? Thanks. |
|
Excellent! |
|
@pixelead0 Thanks so much for this. #442 should be merged in soon and I would love if we can cross check any remaining/fixable translations after that's in. Can't tell you much how we appreciate you taking the time to put this PR up 🙌 |
|
I resolved conflicts with #442 |
|
@pixelead0 thank you <3 Did you rebase from latest master because it still seems like a few conflicts are present. Could you take a look whenever you get the chance 🙏 |
|
Hola @pixelead0 ! Spanish translations have been merged a while ago: Could you give them a review and tell us if there are still changes to be made? 🙏 |
|
Hi there. Our translations files structure completely changed. I'm going to close this PR for now. Thank you again for all your hard work! |
Refs #439
Edited by lex111: we must not close issue #439, because not all translations are exists, and this issue will be open throughout October, while Hacktoberfest passes.