Skip to content

chore: revert changes regarding ip.txt #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chinesedfan merged 1 commit into from
Apr 23, 2018
Merged

chore: revert changes regarding ip.txt #782

chinesedfan merged 1 commit into from
Apr 23, 2018

Conversation

@machour
Copy link
Member

@machour machour commented Apr 22, 2018

Question Response
Version? v1.4.1
Devices tested? iPhone 7
Bug fix? yes
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #780

Description

Rolled back ip.txt related changes.
Closes #780

@machour machour requested a review from chinesedfan April 22, 2018 16:02
@coveralls
Copy link

coveralls commented Apr 22, 2018

Coverage Status

Coverage remained the same at 42.316% when pulling f7f81f8 on machour:revert-ip.txt into a49b431 on gitpoint:master.

@chinesedfan chinesedfan merged commit 7b3ccf0 into gitpoint:master Apr 23, 2018
@machour machour deleted the revert-ip.txt branch April 24, 2018 17:18
@alejandronanez alejandronanez mentioned this pull request Apr 25, 2018
Open
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chinesedfan chinesedfan chinesedfan approved these changes

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revert the commit about ip.txt

3 participants

@machour @coveralls @chinesedfan