Skip to content

Enable tablet #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 5 commits into from
Oct 10, 2018
Merged

Enable tablet #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72408f3
Enable tablet
dy Sep 21, 2018
5d19979
Bump is-mobile
dy Sep 30, 2018
b62dc8f
Fix iOS/iPad flickering
dy Oct 8, 2018
0a0fff7
Preserve drawing buffer
dy Oct 8, 2018
6c1e17e
Make preserveDrawingBuffer mobile-specific
dy Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"gl-shader": "^4.2.1",
"gl-spikes3d": "^1.0.3",
"glslify": "^6.1.0",
"is-mobile": "^0.2.2",
"is-mobile": "^2.0.0",
"mouse-change": "^1.1.1",
"ndarray": "^1.0.16"
},
Expand Down
8 changes: 5 additions & 3 deletions scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var drawTriangle = require('a-big-triangle')
var mouseChange = require('mouse-change')
var perspective = require('gl-mat4/perspective')
var createShader = require('./lib/shader')
var isMobile = require('is-mobile')()
var isMobile = require('is-mobile')({ tablet: true })

function MouseSelect() {
this.mouse = [-1,-1]
Expand Down Expand Up @@ -80,7 +80,8 @@ function createScene(options) {
gl = getContext(canvas,
options.glOptions || {
premultipliedAlpha: true,
antialias: true
antialias: true,
preserveDrawingBuffer: isMobile
})
}
if(!gl) {
Expand Down Expand Up @@ -745,8 +746,9 @@ function createScene(options) {
if(stopped || scene.contextLost) {
return
}
requestAnimationFrame(render)
// this order is important: ios safari sometimes has sync raf
redraw()
requestAnimationFrame(render)
}
render()

Expand Down