Skip to content

fix(android): increase tolerance to tilts and improve landscape checks #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gladiuscode merged 4 commits into from
Jun 28, 2025
Merged

fix(android): increase tolerance to tilts and improve landscape checks #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a890a50
fix(android): sensor listeners registered with maxReportLatencyUs value
gladiuscode May 24, 2025
a948c79
fix: landscape mode check not accounting for pitch
gladiuscode Jun 26, 2025
5ea2f17
fix: add pitch tolerance to improve portrait and upside down detection
gladiuscode Jun 26, 2025
dd09065
feat: increase pitch tolerance and rename tolerance to rollTolerance
gladiuscode Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...d/src/main/java/com/orientationdirector/implementation/OrientationSensorsEventListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ class OrientationSensorsEventListener(
private var mMagneticFieldSensor: Sensor? =
mSensorManager.getDefaultSensor(Sensor.TYPE_MAGNETIC_FIELD)

private var hasRotationSensor: Boolean = mRotationSensor != null
private var hasRotationSensor: Boolean =
mRotationSensor != null
private var hasAccelerometerAndMagneticFieldSensors: Boolean =
mAccelerometerSensor != null && mMagneticFieldSensor != null

Expand Down
15 changes: 11 additions & 4 deletions android/src/main/java/com/orientationdirector/implementation/Utils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ class Utils(private val context: ReactContext) {
val rollDegrees = Math.toDegrees(rollRadians.toDouble()).toFloat()

// This is needed to account for inaccuracy due to subtle movements such as tilting
val tolerance = 20f
val pitchTolerance = 15f
val rollTolerance = 20f

//////////////////////////////////////
// These limits are set based on SensorManager.getOrientation reference
Expand All @@ -38,12 +39,14 @@ class Utils(private val context: ReactContext) {
//
//////////////////////////////////////

val isPitchInLandscapeModeRange = checkIfPitchIsInLandscapeModeRange(pitchDegrees, pitchTolerance)

return when {
rollDegrees.equals(-0f) && (pitchDegrees.equals(0f) || pitchDegrees.equals(-0f)) -> Orientation.FACE_UP
rollDegrees.equals(-180f) && (pitchDegrees.equals(0f) || pitchDegrees.equals(-0f)) -> Orientation.FACE_DOWN
rollDegrees in tolerance..landscapeRightLimit - tolerance -> Orientation.LANDSCAPE_RIGHT
rollDegrees in landscapeLeftLimit + tolerance..-tolerance -> Orientation.LANDSCAPE_LEFT
pitchDegrees in portraitLimit..-0f -> Orientation.PORTRAIT
rollDegrees in rollTolerance..landscapeRightLimit - rollTolerance && isPitchInLandscapeModeRange -> Orientation.LANDSCAPE_RIGHT
rollDegrees in landscapeLeftLimit + rollTolerance..-rollTolerance && isPitchInLandscapeModeRange -> Orientation.LANDSCAPE_LEFT
pitchDegrees in portraitLimit..pitchTolerance -> Orientation.PORTRAIT
else -> Orientation.PORTRAIT_UPSIDE_DOWN
}
}
Expand Down Expand Up @@ -94,4 +97,8 @@ class Utils(private val context: ReactContext) {

return context.currentActivity!!.requestedOrientation;
}

private fun checkIfPitchIsInLandscapeModeRange(pitchDegrees: Float, tolerance: Float): Boolean {
return pitchDegrees > -tolerance && pitchDegrees < tolerance
}
}