Javascript all-objects output should export all converters

[W1M0R]

Version

quicktype version 15.0.258

Command

quicktype \
  --src-lang schema \
  json.schema \
  --lang js \
  --runtime-typecheck \
  --acronym-style pascal \
  --converters all-objects \
  --raw-type any \
  -o output.js

Actual Output

output.js:

...
function toData(json) {
    return cast(json, r("Data"));
}

function dataToJson(value) {
    return uncast(value, r("Data"));
}

function toData123(json) {
    return cast(json, r("Data123"));
}

function data123ToJson(value) {
    return uncast(value, r("Data123"));
}
...
module.exports = {
    "dataToJson": dataToJson,
    "toData": toData,
};

Expected Output

Expected output should also export data123ToJson and toData123:

...
module.exports = {
    "dataToJson": dataToJson,
    "toData": toData,
    "data123ToJson": data123ToJson,
    "toData123": toData123,
};

Explanation

Currently the user is able to create converters for all-objects, but those converters can not be used, since they are not exported. @benquarmby @schani

Related

#1236

[benquarmby]

Interesting. The TypeScript and JavaScript output are quite different. On the TS side there is a Convert class with all converter functions as static members. Convert is a named export. On the JavaScript side each converter function should be a named export, but it is not today.

Looks like there is a defect. I would suggest opening a PR to fix the JS output.

P.S. It would be great if quicktype aligned the exports between TS / JS / Flow. I'm not entirely sure why a class is used when everything is static. Would be a breaking change though.