references in a multi-file json schema don't resolve correctly

[ataibarkai]

given a json schema encoded in the filesystem as such:

schemas/
   validate.json
   events/
      administration.json
      ads.json
      ...
   products/
      administration.json
      ads.json
      ...

references between files don't resolve correctly.

e.g. in schemas/products/administration.json, there is a reference to ../events/administration.json.

quicktype seems to incorrectly infer schemas/products/events/administration.json rather than schemas/events/administration.json as the file path:

quicktype -s schema schemas/validate.json -o models.swift
-->
Error: Could not fetch schema schemas/products/events/administration.json, referred to from schemas/products/administration.json#/allOf/0: Error: Input file schemas/products/events/administration.json does not exist.

example:
schemas.zip

[schani]

Thank you for reporting the issue!

I believe you're using $id incorrectly. If you have a schema in /schemas/products/administration.json which has an $id field of products/administration.json, then a $ref within that schema is resolved relative to /schemas/products/products/administration.json. I'm not an expert on this, so if you are, please correct me. Otherwise please close the issue.

[ataibarkai]

Did you mean to write /schemas/products/administration.json rather than/schemas/products/products/administration.json?

At any rate, I believe it should resolve relative to /schemas/products/, not relative to /schemas/products/administration.json (i.e. relative to the folder containing the file).
I am not an expert either, but a colleague with more experience with json schema seems to think so as well.
In addition, this scheme works fine for us when implementing schema validation on our ruby stack.

Btw, it looks like there is another related bug: when I specified ./events/administration.json in the ref, it got resolved to schemas/products/products/events/administration.json rather than to schemas/products/events/administration.json

[schani]

No, I wrote what I meant to write. See more info here:

https://stackoverflow.com/questions/46671285/id-property-usage-in-json-schema

If you have a schema in /a/b/c.json, and you give it an $id of b/c.json, then its actual base URL will be /a/b/b/c.json, because the $id will be resolved relative to the schema's path - b/c.json relative to /a/b/c.json is /a/b/b/c.json.

[ataibarkai]

Ok, might really be a problem on our end then. I'll look into this.
Thanks for the info

[schani]

If you learn that quicktype does actually behave incorrectly, please report back. I'll close the issue for now.

[schani]

quicktype actually does handle this incorrectly.

A $id in the root should not be resolved relatively. That should at least fix your issues if you add a .json to the $ids.

Ideally, quicktype should also allow adding schemas from arbitrary files and use their root $ids to refer to them.