Skip to content

fix(typescript-zod): preserve null for nullable date-time fields #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schani merged 1 commit into from
Jul 20, 2026
Merged

fix(typescript-zod): preserve null for nullable date-time fields #2966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/quicktype-core/src/language/TypeScriptZod/TypeScriptZodRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,14 @@ export class TypeScriptZodRenderer extends ConvenienceRenderer {
],
(_enumType) => panic("Should already be handled."),
(unionType) => {
const children = Array.from(unionType.getChildren()).map(
(type: Type) => this.typeMapTypeFor(type, false),
);
const children = Array.from(unionType.getChildren())
// Coercing schemas can accept null, so handle it first.
.sort(
(a, b) =>
Number(b.kind === "null") -
Number(a.kind === "null"),
)
.map((type: Type) => this.typeMapTypeFor(type, false));
return ["z.union([", ...arrayIntercalate(", ", children), "])"];
},
(_transformedStringType) => {
Expand Down
3 changes: 0 additions & 3 deletions test/languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1879,9 +1879,6 @@ export const TypeScriptZodLanguage: Language = {
// Does not handle top level array
"bug863.json",

// z.coerce.date() coerces null to the Unix epoch: #2880
"bug2590.json",

"no-classes.json",
"00c36.json",
"10be4.json",
Expand Down
Loading