Skip to content

fix(swift): remove deprecated JSONNull.hashValue #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schani merged 1 commit into from
Jul 22, 2026
+4 −7
Merged

fix(swift): remove deprecated JSONNull.hashValue #3003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/quicktype-core/src/language/Swift/SwiftRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,14 +1183,9 @@ encoder.dateEncodingStrategy = .formatted(formatter)`);
}`);

if (this._options.objcSupport === false) {
this.ensureBlankLine();
this.emitMultiline(` public var hashValue: Int {
return 0
}`);

this.ensureBlankLine();
this.emitMultiline(` public func hash(into hasher: inout Hasher) {
// No-op
hasher.combine(0)
}`);
}

Expand Down
4 changes: 3 additions & 1 deletion test/unit/swift-json-null-hashable.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const schema = JSON.stringify({
required: ["value"],
});

test("emits hash(into:) for JSONNull by default", async () => {
test("emits modern Hashable implementation for JSONNull by default", async () => {
const schemaInput = new JSONSchemaInput(undefined);
await schemaInput.addSource({ name: "TopLevel", schema });

Expand All @@ -24,4 +24,6 @@ test("emits hash(into:) for JSONNull by default", async () => {
const output = result.lines.join("\n");

expect(output).toContain("public func hash(into hasher: inout Hasher)");
expect(output).toContain("hasher.combine(0)");
expect(output).not.toContain("public var hashValue: Int");
});
Loading