fix: sync docs with codebase#72
Conversation
… missing package - architecture.md: fix startup sequence order (handlers register before servers start, not after), expand shutdown sequence to match actual code (9 steps including admin server, graceful stop, force stop), correct options API from Set/Get to AddToOptions/FromContext, add admin port to deployment topology diagram - Packages.md: add missing options package entry - integrations.md: fix Sentry env var RELEASE → RELEASE_NAME - production.md, signals.md: add admin server shutdown step - Index.md: add link to full interceptor chain from simplified diagram
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDocumentation-only updates: added an Options package doc and renamed Options API calls; added a link/enumeration for the server interceptor chain; introduced ADMIN_PORT in deployment topology and updated startup/shutdown sequences (server creation, concurrent listeners, admin handling, drain/wait and shutdown ordering); changed Sentry env var name. Changes
Sequence Diagram(s)sequenceDiagram
participant Init as Init (caller)
participant Core as Core
participant Interceptors as Interceptor Assembly
participant GRPC as gRPC Server
participant HTTP as HTTP Server
participant Admin as Admin Server
participant CBG as CBGracefulStopper
participant CBS as CBStopper
Init->>Core: core.New(cfg)
Core->>Interceptors: init() assemble interceptor chain
Core->>GRPC: create gRPC listener (tcp/unix)
Core->>HTTP: create HTTP listener
alt ADMIN_PORT set
Core->>Admin: create admin listener (metrics/swagger/pprof)
end
par start listeners
GRPC->>GRPC: start serving
HTTP->>HTTP: start serving
Admin->>Admin: start serving
end
Note right of Init: Signal received (TERM/INT)
Init->>CBG: FailCheck(true) -> mark readiness false
Init->>Init: wait drain duration (SHUTDOWN_DURATION_IN_SECONDS)
alt ADMIN_PORT set
Init->>Admin: Shutdown admin server
end
Init->>HTTP: Shutdown HTTP server
Init->>GRPC: GracefulStop gRPC (fallback to ForceStop)
Init->>CBS: Stop() services
Init->>Init: exit
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the documentation to accurately reflect the current ColdBrew codebase behavior and APIs (startup/shutdown flows, options API naming, deployment topology, and integrations).
Changes:
- Align startup/shutdown sequence docs across architecture, production, and signals pages (including admin server and force-stop steps).
- Correct options context propagation API names and expand deployment topology to include optional
ADMIN_PORT. - Add missing
optionspackage docs entry, fix Sentry env var name, and link the homepage diagram to the full interceptor chain.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Packages.md | Adds the missing options package entry and links. |
| integrations.md | Fixes Sentry release environment variable name to RELEASE_NAME. |
| Index.md | Adds a link from the simplified diagram to the full interceptor chain section. |
| howto/signals.md | Updates graceful shutdown steps to match runtime behavior (incl. admin server and force-stop). |
| howto/production.md | Updates production shutdown sequence to match runtime behavior (incl. admin server and force-stop). |
| architecture.md | Syncs options API naming, deployment topology (admin port), and startup/shutdown sequences with codebase behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The drain wait (GRPC_GRACEFUL_DURATION_IN_SECONDS) is included within SHUTDOWN_DURATION_IN_SECONDS, not additional to it. The previous guidance to sum both values was incorrect.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…, step range - Index.md: move interceptor chain link outside fenced code block - architecture.md: add SetReady() step back to startup sequence - signals.md: fix step range reference from 2-8 to 1-8
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Set/Get→AddToOptions/FromContext)optionspackage to Packages pageRELEASE→RELEASE_NAMEin integrations pageTest plan
Summary by CodeRabbit