This repository was archived by the owner on Oct 13, 2021. It is now read-only.
Open
Conversation
|
|
added 2 commits
August 8, 2019 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request will be closed without any reasons if it does not satisfy any of following requirements:
masterbranch, pull requests on release branches are only allowed for bug fixes.You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.
Description
The hash is used in segment.go line 260 to calculate shard index, rigth?
As calculate hash by both docid and content, if the content changes a bit then update the same docid's index, it will be highly possible assigned to another shard, so that there will be duplicated search result with same docid, which is not expected.