Merged
Conversation
Member
|
This seems reasonable to me and thanks for sharing your rationale on #92. We can squash-on-merge. I'm going to leave this open for a week to give others a chance to comment before landing this. After that please feel free to ping the thread and I'll merge unless there are outstanding comments or issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #92
Running
go generatehas brought in a few unwanted changes. I would remove them before merging, but am keeping them for now until I understand where they're coming from.I separated changes to the template and changes from
go generate. Let me know if it would be better to squash the changes.