Skip to content

fix file URL validator#1171

Merged
deankarn merged 1 commit intogo-playground:masterfrom
nodivbyzero:file-url-validator-fix
Nov 4, 2023
Merged

fix file URL validator#1171
deankarn merged 1 commit intogo-playground:masterfrom
nodivbyzero:file-url-validator-fix

Conversation

@nodivbyzero
Copy link
Copy Markdown
Contributor

Fixes Or Enhances

This PR adds an additional check for the file URL schema.
Connected to #1165

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner September 20, 2023 01:36
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 73.864% (+0.02%) from 73.849% when pulling ed3b911 on nodivbyzero:file-url-validator-fix into 8d50f2f on go-playground:master.

Copy link
Copy Markdown
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deankarn deankarn merged commit c856961 into go-playground:master Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants