Skip to content

Introduce a new method mysqlConn.Reset() #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zenovich wants to merge 10 commits into
base: master
Choose a base branch
from
+218 −74
Open

Introduce a new method mysqlConn.Reset() #1734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a3f2c66
introduce a new method mysqlConn.sendNoArgsCommandWithResultOK() base…
zenovich Aug 25, 2025
d6400de
introduce a new method mysqlConn.Reset() allowing to reset the mysql …
zenovich Aug 25, 2025
43cdc22
add Dmitry Zenovich into the list of authors
zenovich Aug 25, 2025
8630716
rename constant comConnReset to comResetConnection, add preceding con…
zenovich Aug 26, 2025
527b0ab
rename method mysqlConn.sendNoArgsCommandWithResultOK() to mysqlConn.…
zenovich Aug 26, 2025
3d484fc
improve the comment of mysqlConn.Reset()
zenovich Aug 26, 2025
272fe81
fix issues in tests TestNoArgsCommand (+ rename it to TestSimpleComma…
zenovich Aug 26, 2025
9c308f1
allow skipping TestReset and TestSimpleCommandOK_Reset when COM_RESET…
zenovich Aug 26, 2025
203cac4
use QueryContext instead of Query in TestSimpleCommandOK and verify r…
zenovich Aug 26, 2025
02afe1d
seed the result with a sentinel explicitly in TestReset
zenovich Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename constant comConnReset to comResetConnection, add preceding con… 
…stants (comDaemon and comBinlogDumpGTID) to make their values auto-generated
  • Loading branch information
@zenovich
zenovich committed Aug 26, 2025
commit 8630716859e32cd546111022a3db457fd0fa1024
2 changes: 1 addition & 1 deletion connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ func (mc *mysqlConn) startWatcher() {

// Reset resets the MySQL connection.
func (mc *mysqlConn) Reset(ctx context.Context) (err error) {
return mc.sendNoArgsCommandWithResultOK(ctx, comConnReset)
return mc.sendNoArgsCommandWithResultOK(ctx, comResetConnection)
}

func (mc *mysqlConn) CheckNamedValue(nv *driver.NamedValue) (err error) {
Expand Down
4 changes: 3 additions & 1 deletion const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ const (
comStmtReset
comSetOption
comStmtFetch
comConnReset = 31
comDaemon
comBinlogDumpGTID
comResetConnection
)

// https://dev.mysql.com/doc/internals/en/com-query-response.html#packet-Protocol::ColumnType
Expand Down